FISH-5749: Asadmin Recorder Generates Invalid Commands for MicroProfile Properties at the Server Level

[raushan606]

Description

When the Asadmin Recorder is active and a MicroProfile config property is saved from the Admin Console at server level, the recorded set command lacks the double-quoting required to make the escaped-dot property key replay-safe from the Asadmin CLI.

Important Info

Blockers

Testing

New tests

Testing Performed

Testing Environment

Documentation

Notes for Reviewers

After the fix, the set commands is like this:
set "servers.server.server.property.payara\.microprofile\.mpkey=mpValue"

[simonladen]

Tested locally

[jtarry-payara]

Still fails if you record a description:

$ cat appserver/distributions/payara/target/stage/payara7/glassfish/domains/domain1/asadmin-commands.txt 
set "property.payara\.microprofile\.payara\.observability\.security\.store\.type=foo" property.payara.microprofile.payara.observability.security.store.type.name=payara.microprofile.payara.observability.security.store.type
set property.payara.microprofile.payara.observability.security.store.type.description=some desc

$ appserver/distributions/payara/target/stage/payara7/bin/asadmin < appserver/distributions/payara/target/stage/payara7/glassfish/domains/domain1/asadmin-commands.txt
Use "exit" to exit and "help" for online help.
Unable to create a system terminal, creating a dumb terminal (enable debug logging for more information)
property.payara.microprofile.payara.observability.security.store.type=foo
property.payara.microprofile.payara.observability.security.store.type.name=payara.microprofile.payara.observability.security.store.type
Command set executed successfully.
remote failure: Invalid name value pair desc. Missing expected equal sign.
Command set failed.
Command multimode failed.

This appears to work ok:

$ cat appserver/distributions/payara/target/stage/payara7/glassfish/domains/domain1/asadmin-commands.txt 
set "property.payara\.microprofile\.payara\.observability\.security\.store\.type=foo" property.payara.microprofile.payara.observability.security.store.type.name=payara.microprofile.payara.observability.security.store.type
set "property.payara.microprofile.payara.observability.security.store.type.description=some desc"

[raushan606]

$ appserver/distributions/payara/target/stage/payara7/bin/asadmin < appserver/distributions/payara/target/stage/payara7/glassfish/domains/domain1/asadmin-commands.txt
Use "exit" to exit and "help" for online help.
Unable to create a system terminal, creating a dumb terminal (enable debug logging for more information)
servers.server.server.property.payara.microprofile.mpkey=mpValue
servers.server.server.property.payara.microprofile.mpkey.name=payara.microprofile.mpkey
Command set executed successfully.
servers.server.server.property.payara.microprofile.mpkey.description=some desc
Command set executed successfully.
servers.server.server.property.payara.microprofile.mpkey1=mpValue
servers.server.server.property.payara.microprofile.mpkey1.name=payara.microprofile.mpkey1
Command set executed successfully.
servers.server.server.property.payara.microprofile.mpkey1.description=
Command set executed successfully.
Command multimode executed successfully.

@jtarry-payara I added two microprofile configs: one with a property and another without a description. Both seem to work fine.

$ cat appserver/distributions/payara/target/stage/payara7/glassfish/domains/domain1/asadmin-commands.txt
set "servers.server.server.property.payara\.microprofile\.mpkey=mpValue" servers.server.server.property.payara.microprofile.mpkey.name=payara.microprofile.mpkey
set "servers.server.server.property.payara.microprofile.mpkey.description=some desc"
set "servers.server.server.property.payara\.microprofile\.mpkey1=mpValue" servers.server.server.property.payara.microprofile.mpkey1.name=payara.microprofile.mpkey1
set servers.server.server.property.payara.microprofile.mpkey1.description=

[jtarry-payara]

LGTM
tested in linux & windows all working well