FISH-13115 update nexus registry creds#8034
FISH-13115 update nexus registry creds#8034abdulrahim458 wants to merge 8 commits intopayara:mainfrom
Conversation
Pandrex247
left a comment
Pandrex247
left a comment
There was a problem hiding this comment.
Community shouldn't require access to the private Enterprise repo
| registries: | ||
| - payara-private-nexus |
There was a problem hiding this comment.
It's not trying to check this repo, it's trying to check the private staging repo
There was a problem hiding this comment.
We should either exclude this repo (as that repo should be disabled by default anyway), and we don't want dependabot prematurely creating PRs for things we're trying to patch - it shouldn't be creating PRs for *.payara-px anyway, and that's the only thing which should really be in there
…5-update-dependabot-private-registry-creds
| - dependency-name: "fish.payara.*" | ||
| update-types: ["version-update:semver-major"] | ||
|
|
||
| - dependency-name: "*payara-px*" |
There was a problem hiding this comment.
I'm not sure this would match anything?
We don't have any dependencies following that naming convention unless I'm overlooking something
There was a problem hiding this comment.
else i can just ignore the failing dependencies to check
- dependency-name: "javax.xml.stream:stax-api"
- dependency-name: "javax.jbi:jbi"
this prevents from failures or else add the staging registry details to dependabot file
There was a problem hiding this comment.
Those dependencies will just be the first ones being polled - there's nothing special about them
|
Before: Dependabot was returning 401 Unauthorized on every request to payara-staging, causing private_source_authentication_failure for javax.jbi:jbi and javax.xml.stream:stax-api. Because of these auth failures, the job was exiting with a non-zero exit code meaning not all dependencies were being evaluated some updates were being silently skipped and no PRs were created for those dependencies. After: With the registry credentials added, payara-staging now correctly returns 404 where artifacts aren't present and falls back to payara-artifacts for Payara-patched dependencies (e.g. *.payara-p1) and Maven Central for everything else. All dependencies are now fully evaluated. The job completes successfully and update PRs are created correctly. Test run: https://github.com/abdulrahim458/Payara/actions/runs/24636034657/job/72031532827 CC: @Pandrex247 |
2 participants
Description
Important Info
Blockers
Testing
New tests
Testing Performed
Testing Environment
Documentation
Notes for Reviewers