FISH-13046 Removed yubikey extension from Payara7#8037
Merged
jtarry-payara merged 2 commits intopayara:mainfrom Mar 25, 2026
Merged
FISH-13046 Removed yubikey extension from Payara7#8037jtarry-payara merged 2 commits intopayara:mainfrom
jtarry-payara merged 2 commits intopayara:mainfrom
Conversation
jtarry-payara
requested review from
Pandrex247,
pdudits,
raushan606 and
simonladen
pdudits
approved these changes
Mar 24, 2026
Pandrex247
approved these changes
Mar 24, 2026
Member
Pandrex247
left a comment
Pandrex247
left a comment
There was a problem hiding this comment.
The copyright year should ideally be updated to 2026 but otherwise LGTM
jtarry-payara
force-pushed
the
FISH-13046-remove-yubikey-extension
branch
from
68743a2 to
b5b9e84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes old Payara5 yubikey implementation of
TwoIdentityStoreAuthenticationMechanismDefinitionthat was based on deprecated legacy YubiKey Java client API which was archived on May 4th, 2021: https://github.com/Yubico/yubico-java-clientImportant Info
Blockers
Testing
New tests
Testing Performed
Tested Payara7 still builds and starts successfully without any yubikey JARs
Testing Environment
Zulu JDK 21.0.10 CRaC on Arch Linux with Maven 3.9.13
Documentation
Notes for Reviewers