Skip to content

fix: use && instead of ; in Dockerfile to fail on frontend build errors#105

Open
paychex-inder wants to merge 1 commit intomainfrom
fix/dockerfile-build-errors
Open

fix: use && instead of ; in Dockerfile to fail on frontend build errors#105
paychex-inder wants to merge 1 commit intomainfrom
fix/dockerfile-build-errors

Conversation

@paychex-inder
Copy link
Copy Markdown
Collaborator

The Dockerfile was using ; to chain commands in the RUN statement, which meant that if npm run frontend failed, the Docker build would still succeed (because the exit code would be from the last command, npm cache clean).

This caused N1 to deploy a broken image where /app/client/dist/index.html was missing because the frontend build had failed silently.

This fix changes ; to && so that build failures properly fail the Docker build.

Root cause of the frontend failure:
The vite build was failing with: "AudioPaths" is not exported by "../packages/client/dist/index.es.js"

This PR ensures such failures are caught at build time.

@github-actions
Copy link
Copy Markdown

Logo
Checkmarx One – Scan Summary & Details2e6165e3-e428-4f52-bc14-82b2a5e9ce46

New Issues (395)

Checkmarx found the following issues in this Pull Request

# Severity Issue Source File / Package Checkmarx Insight
1 CRITICAL CVE-2025-68665 Npm-@langchain/core-0.3.79
detailsRecommended version: 0.3.80
Description: LangChain is a framework for building LLM-powered applications. In @langchain/core versions prior to 0.3.80 and 1.x prior to 1.1.8, and langchain v...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
2 CRITICAL Stored_XSS /api/server/index.js: 64
detailsThe method Lambda embeds untrusted data in generated output with send, at line 163 of /api/server/index.js. This untrusted data is embedded into ...
Attack Vector
3 CRITICAL Stored_XSS /api/server/experimental.js: 228
detailsThe method Lambda embeds untrusted data in generated output with send, at line 328 of /api/server/experimental.js. This untrusted data is embedde...
Attack Vector
4 HIGH Absolute_Path_Traversal /api/server/services/Files/Audio/STTService.js: 332
detailsMethod processSpeechToText at line 332 of /api/server/services/Files/Audio/STTService.js gets dynamic data from the path element. This element’s ...
Attack Vector
5 HIGH Absolute_Path_Traversal /api/server/routes/files/images.js: 56
detailsMethod Lambda at line 56 of /api/server/routes/files/images.js gets dynamic data from the path element. This element’s value then flows through t...
Attack Vector
6 HIGH Absolute_Path_Traversal /api/server/routes/files/files.js: 401
detailsMethod Lambda at line 401 of /api/server/routes/files/files.js gets dynamic data from the path element. This element’s value then flows through t...
Attack Vector
7 HIGH Absolute_Path_Traversal /api/server/routes/files/files.js: 410
detailsMethod Lambda at line 410 of /api/server/routes/files/files.js gets dynamic data from the path element. This element’s value then flows through t...
Attack Vector
8 HIGH Absolute_Path_Traversal /api/server/routes/files/avatar.js: 17
detailsMethod Lambda at line 17 of /api/server/routes/files/avatar.js gets dynamic data from the path element. This element’s value then flows through t...
Attack Vector
9 HIGH Absolute_Path_Traversal /api/server/controllers/assistants/v1.js: 310
detailsMethod Cx0d758712 at line 310 of /api/server/controllers/assistants/v1.js gets dynamic data from the path element. This element’s value then flow...
Attack Vector
10 HIGH Absolute_Path_Traversal /api/server/controllers/agents/v1.js: 608
detailsMethod Cxbbcc721e at line 608 of /api/server/controllers/agents/v1.js gets dynamic data from the path element. This element’s value then flows th...
Attack Vector
11 HIGH Absolute_Path_Traversal /api/server/services/Files/Audio/STTService.js: 349
detailsMethod processSpeechToText at line 349 of /api/server/services/Files/Audio/STTService.js gets dynamic data from the path element. This element’s ...
Attack Vector
12 HIGH Absolute_Path_Traversal /api/server/controllers/agents/v1.js: 660
detailsMethod Cxbbcc721e at line 660 of /api/server/controllers/agents/v1.js gets dynamic data from the path element. This element’s value then flows th...
Attack Vector
13 HIGH Absolute_Path_Traversal /api/server/routes/files/avatar.js: 41
detailsMethod Lambda at line 41 of /api/server/routes/files/avatar.js gets dynamic data from the path element. This element’s value then flows through t...
Attack Vector
14 HIGH Absolute_Path_Traversal /api/server/controllers/assistants/v1.js: 368
detailsMethod Cx0d758712 at line 368 of /api/server/controllers/assistants/v1.js gets dynamic data from the path element. This element’s value then flow...
Attack Vector
15 HIGH Absolute_Path_Traversal /api/server/services/Files/Audio/STTService.js: 376
detailsMethod speechToText at line 376 of /api/server/services/Files/Audio/STTService.js gets dynamic data from the req element. This element’s value th...
Attack Vector
16 HIGH Absolute_Path_Traversal /api/server/services/Files/Audio/STTService.js: 376
detailsMethod speechToText at line 376 of /api/server/services/Files/Audio/STTService.js gets dynamic data from the req element. This element’s value th...
Attack Vector
17 HIGH CVE-2025-66414 Npm-@modelcontextprotocol/sdk-1.21.0
detailsRecommended version: 1.26.0
Description: MCP TypeScript SDK is the official TypeScript SDK for Model Context Protocol servers and clients. Prior to 1.24.0, The Model Context Protocol (MCP)...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
18 HIGH CVE-2026-0621 Npm-@modelcontextprotocol/sdk-1.21.0
detailsRecommended version: 1.26.0
Description: Anthropic's MCP TypeScript SDK versions through 1.25.1 contain a Regular Expression Denial-of-Service (ReDoS) vulnerability in the "UriTemplate" cl...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
19 HIGH CVE-2026-22036 Npm-undici-7.16.0
detailsRecommended version: 7.18.2
Description: Undici is an HTTP/1.1 client for Node.js. In Undici versions prior to 6.23.0 and 7.x prior to 7.18.2, the number of links in the decompression chai...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
20 HIGH CVE-2026-25128 Npm-fast-xml-parser-4.4.1
detailsRecommended version: 5.3.4
Description: fast-xml-parser allows users to validate XML, parse XML to JS object, or build XML from JS object without C/C++ based libraries and no callback. In...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
21 HIGH CVE-2026-25128 Npm-fast-xml-parser-5.0.9
detailsRecommended version: 5.3.4
Description: fast-xml-parser allows users to validate XML, parse XML to JS object, or build XML from JS object without C/C++ based libraries and no callback. In...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
22 HIGH CVE-2026-25128 Npm-fast-xml-parser-5.2.5
detailsRecommended version: 5.3.4
Description: fast-xml-parser allows users to validate XML, parse XML to JS object, or build XML from JS object without C/C++ based libraries and no callback. In...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
23 HIGH CVE-2026-25536 Npm-@modelcontextprotocol/sdk-1.21.0
detailsRecommended version: 1.26.0
Description: MCP TypeScript SDK is the official TypeScript SDK for Model Context Protocol servers and clients. From version 1.10.0 through 1.25.3, cross-client ...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
24 HIGH CVE-2026-25639 Npm-axios-1.12.1
detailsRecommended version: 1.13.5
Description: Axios is a promise based HTTP client for the browser and Node.js. Prior to 1.13.5, the mergeConfig function in axios crashes with a TypeError when ...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
25 HIGH Cxdca8e59f-8bfe Npm-inflight-1.0.6
detailsDescription: In NPM `inflight` there is a Memory Leak because some resources are not freed correctly after being used. It appears to affect all versions, as the...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
26 HIGH JWT_No_Signature_Verification /api/strategies/appleStrategy.test.js: 84
detailsThe JWT is not properly verified at the decode in 84 at the file /api/strategies/appleStrategy.test.js.
Attack Vector
27 HIGH JWT_No_Signature_Verification /api/strategies/appleStrategy.js: 19
detailsThe JWT is not properly verified at the decode in 19 at the file /api/strategies/appleStrategy.js.
Attack Vector
28 HIGH Prototype_Pollution /api/server/routes/mcp.js: 420
detailsAn unsafe object assignment occurred in /api/server/routes/mcp.js at line 433. Assigning external properties without validation may allow object ...
Attack Vector
29 HIGH Prototype_Pollution /api/server/services/Runs/StreamRunManager.js: 602
detailsAn unsafe object assignment occurred in /api/server/services/Runs/StreamRunManager.js at line 343. Assigning external properties without validati...
Attack Vector
30 HIGH Prototype_Pollution /api/server/services/Runs/StreamRunManager.js: 407
detailsAn unsafe object assignment occurred in /api/server/services/Runs/StreamRunManager.js at line 343. Assigning external properties without validati...
Attack Vector
31 HIGH Reflected_XSS /api/server/routes/prompts.js: 244
detailsThe method Cxfa01cb0c embeds untrusted data in generated output with send, at line 280 of /api/server/routes/prompts.js. This untrusted data is e...
Attack Vector
32 HIGH Reflected_XSS /api/server/routes/config.js: 87
detailsThe method Lambda embeds untrusted data in generated output with send, at line 194 of /api/server/routes/config.js. This untrusted data is embedd...
Attack Vector
33 HIGH Reflected_XSS /api/server/routes/prompts.js: 456
detailsThe method Cxaf637b56 embeds untrusted data in generated output with send, at line 460 of /api/server/routes/prompts.js. This untrusted data is e...
Attack Vector
34 HIGH Reflected_XSS /api/server/controllers/AuthController.js: 63
detailsThe method Cx6776623a embeds untrusted data in generated output with send, at line 137 of /api/server/controllers/AuthController.js. This untrust...
Attack Vector
35 HIGH Reflected_XSS /api/server/controllers/UserController.js: 115
detailsThe method Cx94e49a40 embeds untrusted data in generated output with send, at line 123 of /api/server/controllers/UserController.js. This untrust...
Attack Vector
36 HIGH Reflected_XSS /api/server/controllers/AuthController.js: 63
detailsThe method Cx6776623a embeds untrusted data in generated output with send, at line 111 of /api/server/controllers/AuthController.js. This untrust...
Attack Vector
37 HIGH Reflected_XSS /api/server/routes/keys.js: 30
detailsThe method Lambda embeds untrusted data in generated output with send, at line 32 of /api/server/routes/keys.js. This untrusted data is embedded ...
Attack Vector
38 HIGH Reflected_XSS /api/server/routes/prompts.js: 295
detailsThe method Cx011dc025 embeds untrusted data in generated output with send, at line 312 of /api/server/routes/prompts.js. This untrusted data is e...
Attack Vector
39 HIGH Reflected_XSS /api/server/routes/keys.js: 31
detailsThe method Lambda embeds untrusted data in generated output with send, at line 32 of /api/server/routes/keys.js. This untrusted data is embedded ...
Attack Vector
40 HIGH Reflected_XSS /api/server/routes/prompts.js: 296
detailsThe method Cx011dc025 embeds untrusted data in generated output with send, at line 312 of /api/server/routes/prompts.js. This untrusted data is e...
Attack Vector
41 HIGH Reflected_XSS /api/server/routes/prompts.js: 160
detailsThe method Lambda embeds untrusted data in generated output with send, at line 215 of /api/server/routes/prompts.js. This untrusted data is embed...
Attack Vector
42 HIGH Reflected_XSS /api/server/routes/prompts.js: 455
detailsThe method Cxaf637b56 embeds untrusted data in generated output with send, at line 460 of /api/server/routes/prompts.js. This untrusted data is e...
Attack Vector
43 HIGH Reflected_XSS /api/server/routes/prompts.js: 160
detailsThe method Lambda embeds untrusted data in generated output with send, at line 229 of /api/server/routes/prompts.js. This untrusted data is embed...
Attack Vector
44 HIGH Reflected_XSS /api/server/routes/roles.js: 59
detailsThe method Lambda embeds untrusted data in generated output with send, at line 86 of /api/server/routes/roles.js. This untrusted data is embedded...
Attack Vector
45 HIGH Reflected_XSS /api/server/controllers/auth/LogoutController.js: 8
detailsThe method Cxf2fd7c1a embeds untrusted data in generated output with send, at line 38 of /api/server/controllers/auth/LogoutController.js. This u...
Attack Vector
46 HIGH Reflected_XSS /api/server/routes/prompts.js: 81
detailsThe method Lambda embeds untrusted data in generated output with send, at line 90 of /api/server/routes/prompts.js. This untrusted data is embedd...
Attack Vector
47 HIGH Reflected_XSS /api/server/routes/prompts.js: 475
detailsThe method Cxb85e2db2 embeds untrusted data in generated output with send, at line 478 of /api/server/routes/prompts.js. This untrusted data is e...
Attack Vector
48 HIGH Reflected_XSS /api/server/routes/prompts.js: 409
detailsThe method Lambda embeds untrusted data in generated output with send, at line 428 of /api/server/routes/prompts.js. This untrusted data is embed...
Attack Vector
49 HIGH Reflected_XSS /api/server/routes/prompts.js: 400
detailsThe method Lambda embeds untrusted data in generated output with send, at line 402 of /api/server/routes/prompts.js. This untrusted data is embed...
Attack Vector
50 HIGH Reflected_XSS /api/server/routes/share.js: 58
detailsThe method Lambda embeds untrusted data in generated output with send, at line 71 of /api/server/routes/share.js. This untrusted data is embedded...
Attack Vector
51 HIGH Reflected_XSS /api/server/routes/prompts.js: 408
detailsThe method Lambda embeds untrusted data in generated output with send, at line 437 of /api/server/routes/prompts.js. This untrusted data is embed...
Attack Vector
52 HIGH Reflected_XSS /api/server/routes/prompts.js: 383
detailsThe method Lambda embeds untrusted data in generated output with send, at line 385 of /api/server/routes/prompts.js. This untrusted data is embed...
Attack Vector
53 HIGH Reflected_XSS /api/server/controllers/AuthController.js: 63
detailsThe method Cx6776623a embeds untrusted data in generated output with send, at line 94 of /api/server/controllers/AuthController.js. This untruste...
Attack Vector
54 HIGH Reflected_XSS /api/server/routes/prompts.js: 342
detailsThe method Cx0e3424e3 embeds untrusted data in generated output with send, at line 358 of /api/server/routes/prompts.js. This untrusted data is e...
Attack Vector
55 HIGH Reflected_XSS /api/server/routes/prompts.js: 349
detailsThe method Cx0e3424e3 embeds untrusted data in generated output with send, at line 358 of /api/server/routes/prompts.js. This untrusted data is e...
Attack Vector
56 HIGH Reflected_XSS /api/server/controllers/AuthController.js: 20
detailsThe method Cxc178e465 embeds untrusted data in generated output with send, at line 22 of /api/server/controllers/AuthController.js. This untruste...
Attack Vector
57 HIGH Reflected_XSS /api/server/routes/prompts.js: 349
detailsThe method Cx0e3424e3 embeds untrusted data in generated output with send, at line 351 of /api/server/routes/prompts.js. This untrusted data is e...
Attack Vector
58 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 1365
detailsThe method Lambda embeds untrusted data in generated output with location, at line 1368 of /api/server/routes/__tests__/mcp.spec.js. This un...
Attack Vector
59 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 1413
detailsThe method Lambda embeds untrusted data in generated output with location, at line 1415 of /api/server/routes/__tests__/mcp.spec.js. This un...
Attack Vector
60 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 594
detailsThe method Lambda embeds untrusted data in generated output with location, at line 600 of /api/server/routes/__tests__/mcp.spec.js. This unt...
Attack Vector
61 HIGH Reflected_XSS /api/server/routes/share.js: 53
detailsThe method Lambda embeds untrusted data in generated output with send, at line 71 of /api/server/routes/share.js. This untrusted data is embedded...
Attack Vector
62 HIGH Reflected_XSS /api/server/routes/share.js: 56
detailsThe method Lambda embeds untrusted data in generated output with send, at line 71 of /api/server/routes/share.js. This untrusted data is embedded...
Attack Vector
63 HIGH Reflected_XSS /api/server/routes/share.js: 54
detailsThe method Lambda embeds untrusted data in generated output with send, at line 71 of /api/server/routes/share.js. This untrusted data is embedded...
Attack Vector
64 HIGH Reflected_XSS /api/server/routes/share.js: 51
detailsThe method Lambda embeds untrusted data in generated output with send, at line 71 of /api/server/routes/share.js. This untrusted data is embedded...
Attack Vector
65 HIGH Reflected_XSS /api/server/routes/share.js: 62
detailsThe method Lambda embeds untrusted data in generated output with send, at line 71 of /api/server/routes/share.js. This untrusted data is embedded...
Attack Vector
66 HIGH Reflected_XSS /api/server/routes/files/files.js: 41
detailsThe method Lambda embeds untrusted data in generated output with send, at line 54 of /api/server/routes/files/files.js. This untrusted data is em...
Attack Vector
67 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 261
detailsThe method Lambda embeds untrusted data in generated output with location, at line 266 of /api/server/routes/__tests__/mcp.spec.js. This unt...
Attack Vector
68 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 553
detailsThe method Lambda embeds untrusted data in generated output with location, at line 559 of /api/server/routes/__tests__/mcp.spec.js. This unt...
Attack Vector
69 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 495
detailsThe method Lambda embeds untrusted data in generated output with location, at line 501 of /api/server/routes/__tests__/mcp.spec.js. This unt...
Attack Vector
70 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 454
detailsThe method Lambda embeds untrusted data in generated output with location, at line 460 of /api/server/routes/__tests__/mcp.spec.js. This unt...
Attack Vector
71 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 409
detailsThe method Lambda embeds untrusted data in generated output with location, at line 415 of /api/server/routes/__tests__/mcp.spec.js. This unt...
Attack Vector
72 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 374
detailsThe method Lambda embeds untrusted data in generated output with location, at line 380 of /api/server/routes/__tests__/mcp.spec.js. This unt...
Attack Vector
73 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 338
detailsThe method Lambda embeds untrusted data in generated output with location, at line 344 of /api/server/routes/__tests__/mcp.spec.js. This unt...
Attack Vector
74 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 281
detailsThe method Lambda embeds untrusted data in generated output with location, at line 287 of /api/server/routes/__tests__/mcp.spec.js. This unt...
Attack Vector
75 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 270
detailsThe method Lambda embeds untrusted data in generated output with location, at line 275 of /api/server/routes/__tests__/mcp.spec.js. This unt...
Attack Vector
76 HIGH Reflected_XSS /api/server/routes/banner.js: 9
detailsThe method Lambda embeds untrusted data in generated output with send, at line 9 of /api/server/routes/banner.js. This untrusted data is embedded...
Attack Vector
77 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 144
detailsThe method Lambda embeds untrusted data in generated output with location, at line 150 of /api/server/routes/__tests__/mcp.spec.js. This unt...
Attack Vector
78 HIGH Reflected_XSS /api/server/routes/__tests__/mcp.spec.js: 251
detailsThe method Lambda embeds untrusted data in generated output with location, at line 257 of /api/server/routes/__tests__/mcp.spec.js. This unt...
Attack Vector

More results are available on the CxOne platform

@paychex-joser
Copy link
Copy Markdown

If this PR is still required, can you please update the target to be the develop branch instead of main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants