fix: use && instead of ; in Dockerfile to fail on frontend build errors#105
Open
paychex-inder wants to merge 1 commit intomainfrom
Open
fix: use && instead of ; in Dockerfile to fail on frontend build errors#105paychex-inder wants to merge 1 commit intomainfrom
paychex-inder wants to merge 1 commit intomainfrom
Conversation
|
New Issues (395)Checkmarx found the following issues in this Pull Request
|
paychex-joser
approved these changes
Mar 6, 2026
|
If this PR is still required, can you please update the target to be the develop branch instead of main? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The Dockerfile was using
;to chain commands in the RUN statement, which meant that ifnpm run frontendfailed, the Docker build would still succeed (because the exit code would be from the last command,npm cache clean).This caused N1 to deploy a broken image where
/app/client/dist/index.htmlwas missing because the frontend build had failed silently.This fix changes
;to&&so that build failures properly fail the Docker build.Root cause of the frontend failure:
The vite build was failing with:
"AudioPaths" is not exported by "../packages/client/dist/index.es.js"This PR ensures such failures are caught at build time.