Open
Conversation
Mark the built ESM and CJS outputs with package manifests and verify both entrypoints expose named exports. This keeps Node from treating the import target as CommonJS and catches packaging regressions during build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsonfiles intodist/esmanddist/cjsso Node resolves each output with the correct module typeverify:diststep to confirm named exports are available from both published entrypointsWhy
This fixes #59, where enums such as
CaptureStatuswere exported from source but not available to ESM consumers at runtime.Test plan
npm installnpm run buildimport { OrderStatus, CaptureStatus } from '@paypal/paypal-server-sdk'works in an ESM Node runrequire('@paypal/paypal-server-sdk')still works in CommonJS