Skip to content

docs: Add bilingual issue templates and PR template (#47)#76

Merged
pbialon merged 1 commit into
mainfrom
docs/47-issue-pr-templates
Apr 25, 2026
Merged

docs: Add bilingual issue templates and PR template (#47)#76
pbialon merged 1 commit into
mainfrom
docs/47-issue-pr-templates

Conversation

@przemyslawbialon

Copy link
Copy Markdown
Collaborator

Closes #47. Second of three remaining items in the Community-ready milestone (due 2026-04-28).

What's new

Six issue templates (3 types × PL/EN) — GitHub shows them as a dropdown when users click "New issue":

File Dropdown label Labels auto-applied
bug_report_en.md 🇬🇧 Bug report bug
bug_report_pl.md 🇵🇱 Zgłoszenie błędu bug
feature_request_en.md 🇬🇧 Feature request enhancement
feature_request_pl.md 🇵🇱 Propozycja funkcji enhancement
broker_support_en.md 🇬🇧 Broker support request broker-support, help wanted
broker_support_pl.md 🇵🇱 Prośba o obsługę brokera broker-support, help wanted

Plus config.yml (blank issues disabled, 3 contact links to Discussions) and PULL_REQUEST_TEMPLATE.md (EN, contributor-facing).

Added label: broker-support (color #5319e7).

Design notes

  • Bilingual strategy: flags in name: rather than separate folders. Users pick their language from dropdown, then template is fully in that language — no mixed content to edit.
  • Bug template prompts for sanitized CSV with a PII warning — directly influenced by @inobrevi's excellent Revolut: CSV has changed and script doesn't work anymore #33 report which included exactly the minimal CSV we needed. Replicating that pattern.
  • "Known quirks" section in broker_support — lessons from Revolut: CSV has changed and script doesn't work anymore #33 encoded as prompts: BOM? locale? sign position? Forces the reporter to think about edge cases before we do.
  • PR template tax-correctness section — first review gate, not buried in a general checklist. Any change touching tax math must state whether output changes and why.

Acceptance criteria (#47)

  • .github/ISSUE_TEMPLATE/bug_report.md → split into _en / _pl
  • .github/ISSUE_TEMPLATE/feature_request.md → same
  • .github/ISSUE_TEMPLATE/broker_support_request.md → same
  • .github/ISSUE_TEMPLATE/config.yml (blank disabled, Discussions links)
  • .github/PULL_REQUEST_TEMPLATE.md
  • Templates tested manually via GitHub's preview (will verify post-merge in the live dropdown)

Related

Six Markdown issue templates (3 types × PL/EN) let reporters pick their
preferred language from GitHub's "New issue" dropdown. The flag emoji in
each template's `name:` makes the choice visually obvious. One shared
`config.yml` disables blank issues and points tax-rule Q&A toward
Discussions (opened in #48).

Templates mirror each other across languages and include sections
tailored to pit-38's domain:

- bug_report_{en,pl}.md — environment, sanitized CSV snippet (with PII
  warning), expected vs actual output with encouragement to cite the
  ustawa article
- feature_request_{en,pl}.md — user story in "Polish investor" form,
  motivation, scope/out-of-scope
- broker_support_{en,pl}.md — broker name/region, asset class, sanitized
  sample, operation types observed, "known quirks" (BOM, locale, sign
  position) directly informed by #33's lessons

config.yml:
- blank_issues_enabled: false → force template selection
- three contact links: Q&A in EN + PL, Broker support discussion

PULL_REQUEST_TEMPLATE.md (English, with a note inviting PL comments
because contributors are increasingly international):
- Summary + Closes #
- Tax-correctness impact (bespoke — pit-38's most important review gate)
- Testing checklist
- Documentation checklist (TAX_RULES.md, CHANGELOG, TAX_LAW_AUDIT)

Also adds the `broker-support` label so broker-request issues are
auto-tagged.

Closes #47.
@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@pbialon pbialon merged commit f6097dd into main Apr 25, 2026
5 checks passed
@pbialon pbialon deleted the docs/47-issue-pr-templates branch April 25, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

meta: Add GitHub issue and PR templates

2 participants