Skip to content

add prettier extension to the workspace and set format on Save=true#17

Open
mahmoudmoravej wants to merge 1 commit into
pbteja1998:mainfrom
mahmoudmoravej:add-prettier-extension-defaults
Open

add prettier extension to the workspace and set format on Save=true#17
mahmoudmoravej wants to merge 1 commit into
pbteja1998:mainfrom
mahmoudmoravej:add-prettier-extension-defaults

Conversation

@mahmoudmoravej
Copy link
Copy Markdown
Contributor

Let's recommend installing prettier extension by default.
Also allowing formating on save makes the life less dependent on "yarn format" command

@mahmoudmoravej
Copy link
Copy Markdown
Contributor Author

@pbteja1998 if you agree 😄

@jameswinegar
Copy link
Copy Markdown

IDE-specific settings should typically be in .gitignore, and validation should be run via a GitHub action.

@mahmoudmoravej
Copy link
Copy Markdown
Contributor Author

mahmoudmoravej commented Feb 22, 2024

IDE-specific settings should typically be in .gitignore, and validation should be run via a GitHub action.

@jameswinegar Any specific reason behind it? There is lots of value for having it while it doesn't affect other IDEs. Remix also use this pattern: https://github.com/remix-run/remix/blob/main/.vscode/extensions.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants