add prettier extension to the workspace and set format on Save=true#17
Open
mahmoudmoravej wants to merge 1 commit into
Open
add prettier extension to the workspace and set format on Save=true#17mahmoudmoravej wants to merge 1 commit into
mahmoudmoravej wants to merge 1 commit into
Conversation
Contributor
Author
|
@pbteja1998 if you agree 😄 |
|
IDE-specific settings should typically be in .gitignore, and validation should be run via a GitHub action. |
Contributor
Author
@jameswinegar Any specific reason behind it? There is lots of value for having it while it doesn't affect other IDEs. Remix also use this pattern: https://github.com/remix-run/remix/blob/main/.vscode/extensions.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's recommend installing prettier extension by default.
Also allowing formating on save makes the life less dependent on "yarn format" command