ENH: ui exporter#638
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new command-line option to
typhos:Which creates a pydm ui file facsimile of the typhos screen.
This will be used to semi-automatically create pre-filled PyDM screens that can then be tweaked manually. These PyDM screens will not have dependencies on the typhos package, only on stock PyDM widgets.
Things that are covered:
Some follow-up tasks for possibly a later PR, possibly never
Motivation and Context
We're starting to migrate away from using typhos at LCLS to make it easier for us to handle specific user requests for screens, which includes domain-specific ideas but also better UX in general, which is not easily achievable in a fully-automated display generation system.
Additional Changes
Release Notes
I've also gone ahead and discontinued the pre-release notes system. I'm going to be discontinuing this on all of our libraries over time. I've found it extremely cumbersome and redundant compared to just linking to the github releases page.
In lieu of this, I'm going to pay more attention to PR descriptions as release note components.
uv
I like uv, I will use it
pre-commit and ruff
I've applied pre-commit and ruff rules to the repository
How Has This Been Tested?
Interactively only on a half-dozen devices.
I couldn't figure out a reasonable way to make a unit test for this, since it only works on EPICS signals and I didn't want to create real EPICS signals to test on.
Where Has This Been Documented?
Here only
Pre-merge checklist
New/changed functions and methods are covered in the test suite where possibleRandocs/pre-release-notes.shand created a pre-release documentation pagePre-release docs include context, functional descriptions, and contributors as appropriate