still working on app.put#24
Open
scl9087 wants to merge 3 commits into
Open
Conversation
bwreid
reviewed
Jul 20, 2019
|
|
||
| if (!name) { | ||
| const message = `Could not find vegetable with name of ${name}` | ||
| next({ status: 404, message }) |
Contributor
There was a problem hiding this comment.
We actually don't want to stop the request here. If there's no name, that's ok, we should return all of the vegetables.
| let veggie; | ||
| for(let i = 0; i < data.vegetables.length; i++) { | ||
| if (vegetables[i].id === id) { | ||
| veggie.name = req.body.name |
Contributor
There was a problem hiding this comment.
I am unable to get through this route. I think the problem is that you've declared veggie up above, which means its value is set to undefined. You are then trying to assign a property of .name to it. This will result in a failure.
|
|
||
| }) | ||
|
|
||
| // Fruits |
Contributor
There was a problem hiding this comment.
Looks like you're missing the PUT method here..?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.