ci: make CI EBADENGINE-free (Node 20-only jobs, codecov v5)#43
Merged
Conversation
Two remaining CI log warnings: - `codecov/codecov-action@v3` targets the deprecated Node 20 action runtime. Bump to v5 (and rename the now-`files` input). - Installing devDependencies (commitlint@18, eslint@9, both Node 18+) on the Node 16 matrix entry emitted `npm warn EBADENGINE`. Node 16 is EOL (2023-09), so drop it; the matrix now covers 18.x and 20.x. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
These tooling jobs ran on Node 18, where the npm@11.6.2 override (needs Node ^20.17 || >=22.9) floods install with EBADENGINE warnings. They are environment-independent, so move them to Node 20. Only the test matrix's 18.x entry still emits EBADENGINE now. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Node 18 reached EOL on 2025-04-30 and was the last job emitting EBADENGINE (npm@11.6.2 override requires Node 20+). Test only on 20.x and move the Codecov upload to the 20.x job. CI is now EBADENGINE-free. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
pchuri
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drives the CI logs down to zero install/engine warnings. CI was already green; this is warning cleanup.
Root cause
The
overrides-pinnednpm@11.6.2(and its@npmcli/*/@isaacs/*sub-deps) requires Node^20.17 || >=22.9. Every job running on Node 16/18 therefore floodednpm ciwithnpm warn EBADENGINE. Node 16 (EOL 2023-09) and Node 18 (EOL 2025-04) are both past end-of-life.Changes
securityandcommitlintbumped from 18 → 20;testmatrix reduced to[20.x](was[16.x, 18.x, 20.x]). Eliminates EBADENGINE across every job.codecov/codecov-action@v3→@v5(clears its Node 20 action-runtime deprecation; renamed inputfile→files; moved the upload to the 20.x job).Verified
Not actionable here (left as-is)
actions/github-scriptNode 20 deprecation — emitted from insidecodecov-action@v5(already latest); needs a Codecov upstream fix.DEP0040 punycode/DEP0169 url.parse— from transitive dependencies, not our code.enginesstays>=14.0.0; CI now only exercises Node 20, so tightening the supported range is a separate support-policy decision.🤖 Generated with Claude Code