Adding UTF8 support#22
Conversation
|
@elpdt852 Just a heads up that I'm effectively pinning nix version to I'll create an issue in @figsoda's lib and see if I have some time to put up a PR. |
|
Does that mean adding utf8 support will make globset incompatible with Nix later than |
@elpdt852 As it stands, yes. I'll see if I can take a crack at figsoda/utf8#18, release a new version and use that here. That should remove this constraint. |
|
Ok thanks, as it stands then we should hold-off on merging this. |
|
just released v0.1.2 with the fix, sorry about the delay |
No problem, thanks for the fix! |
9a167c2 to
facd557
Compare
facd557 to
a1a1a47
Compare
Closes #5
Inspired by @figsoda's PR: #12 (it was easier to create a new PR since this one doesn't add
?support and resolving merge conflicts would've been significantly harder)Added unit and integration tests for new cases