Skip to content

[HN-042] Content-Disposition header inconsistent across download/export routes #458

Description

@Inakitajes

Problem

Three download/export routes use three different Content-Disposition formats. files/download emits RFC 6266 correct (filename="..."; filename*=UTF-8''...). flows/export emits only filename="..." with no UTF-8 extended form. skills/export places the unsanitized URL path param inside the quoted legacy filename, risking a malformed header.

Location

apps/web/src/app/api/w/[slug]/files/download/route.ts:60; apps/web/src/app/api/u/[slug]/flows/[id]/export/route.ts:60; apps/web/src/app/api/u/[slug]/skills/[name]/export/route.ts:38

Impact

Wrong download names for non-ASCII names and a potential malformed-header risk on skills export.

Suggested fix

Standardize on one helper that emits a sanitized ASCII filename="..." plus filename*=UTF-8''<encoded>, and use it in all three routes.

Source: code investigation.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions