Repository navigation
fix: add B suffix to humanized byte sizes below 1K (#817) - #884
Open
terryrankine wants to merge 1 commit into
Open
terryrankine wants to merge 1 commit into
terryrankine wants to merge 1 commit into
Conversation
ls --humanize and du --humanize printed sizes under 1K as a bare
number, e.g. "123", while larger sizes carry a unit ("1.5K"). Print
"123B" so every humanized size has a unit.
Fixes peak#817
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
3 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #817.
ls -H/du -Hprinted sizes below 1 KiB as a bare number (512) next to suffixed values (1.5K).Fix
strutil.HumanizeBytesappendsBwhen no larger unit applies:512B. The 1024 boundary is unchanged (1024B, since the existing comparison isb > div).Tests
TestHumanizeBytes(0, 1, 999, 1023, 1024, 1025, 1536, 1 MiB ±1, 5 GiB, 3 TiB).TestListS3ObjectsWithDashHgains a 20-byte object asserting20B. No other e2e expectations involve sub-KiB humanized sizes.Linux, Go 1.24,
go test -count=1 -race ./...: all packagesok.gofmt,go vet,staticcheck,unparam,semgrep: clean.🤖 Generated with Claude Code