Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
crypto/x509reject TLS chains that contain eight compromised eMudhra intermediate CAs. Binaries built with older toolchains still accept them, so a certificate signed with one of those keys passes verification when s5cmd connects to an S3 endpoint.Solution
1.22→1.26for both the GCS test job and the release job.golang:1.22-alpine→golang:1.26-alpine.1.26.xadded to thebuildandtestmatrices. Thegodirective ingo.modstays at1.20.1.26.xis not added to theqamatrix. The vendoredgolang.org/x/toolsused bymake bootstrapdoes not compile on Go ≥ 1.23 (tokeninternal.go: invalid array length). The tooling update in Major dependency update and bugfix #878 would fix that.Verification
go vetandgo test -mod=vendor ./...pass ingolang:1.26.10-bookwormand ingolang:1.22-bookworm.docker build .succeeds, and the resulting binary reportsgo1.26.10.