Open
Conversation
Collaborator
|
What "problem" is actually being solved. I'm need to better understand what use case was being attempted that necessitated the requested change |
Author
|
Hi @schaveyt , Concretely:
That breaks discovery scenarios such as:
After this change, those listing scenarios started working in the same environment. So this PR is not introducing a new feature. It fixes document/module enumeration for deployments where the previous query and mapping assumptions were too strict. |
Collaborator
|
Will evaluate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
GetModulesThinAsyncandGetModulesInSpaceThinAsyncso document listing works reliably in environments where the previous module query returned incomplete or no usable results.Changes
doc.FK_PROJECT = proj.C_PKmoduleNameand use it as fallback whenidis missingImpact