fix(withdraw): amount card says 'You're withdrawing', not 'You're sending'#2409
Merged
Conversation
…ding'
The withdraw amount card sat under a 'Withdraw' header but read 'You're
sending' — a copy seam where the frame is named by user intent while the
card was named by the underlying mechanism (a crypto withdrawal is a send
to an address). It also clashed with the ADD_MONEY sibling ('You're
adding') and was plainly wrong for the bank (WITHDRAW_BANK_ACCOUNT) path,
which doesn't 'send' to a bank. Unify to 'You're withdrawing'.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WalkthroughChangesWithdrawal wording alignment
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Code-analysis diffPainscore total: 6129.29 → 6129.55 (+0.26) 🆕 New findings (1)
✅ Resolved (1)
|
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
abalinda
approved these changes
Jul 13, 2026
Hugo0
marked this pull request as ready for review
July 13, 2026 17:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The withdraw amount card sits under a Withdraw header but read "You're sending". This is a copy seam: the page frame is named by the user's intent (Withdraw — how they got there), while the card was named by the mechanism (a crypto withdrawal is, under the hood, a
sendMoney/charge send of USDC to an external address). Both are "true", but they collide in one viewport and read as a bug.Two things made it clearly wrong rather than merely debatable:
ADD_MONEY→ "You're adding", which does match its own header.WITHDRAW_BANK_ACCOUNT) reuses the same string — and you don't "send" to a bank.Unify both
WITHDRAWandWITHDRAW_BANK_ACCOUNTto "You're withdrawing" — matches the header and theADD_MONEYsibling, and reads correctly for crypto and bank.Changes (copy-only, no architecture change)
PeanutActionDetailsCard—WITHDRAW/WITHDRAW_BANK_ACCOUNTbranch → "You're withdrawing" (covers the crypto withdraw +[country]/bankscreens, which render the shared card).withdraw/manteca/page.tsx— two hardcoded literals (the regional/bank withdraw review + status cards) → "You're withdrawing".The internal
PaymentSuccessView type="SEND"semantic key is intentionally left as-is — it's a routing key, not user-visible copy.Design notes / accepted trade-offs
The shared money-movement components (
PeanutActionDetailsCard,PaymentSuccessView,sendMoney/charges) being reused across send/withdraw/add/claim is deliberate, correct factoring — not touched. This is a label fix at that shared seam, not a flow change.Risk
Minimal — three string literals, no logic/type/import changes. Blast radius = the withdraw amount card title on crypto + bank withdraw screens.
QA
typecheck(exit 0),prettier --check(clean), jest (withdraw-states + add-money-states pass; full suite green aftercopy-flagsprebuild)./withdraw→ crypto → amount card header reads "You're withdrawing"; same on the Manteca/bank withdraw review + status cards.