Skip to content

fix(deposit): update Bridge SEPA account holder name + deposit details bugs#2417

Open
kushagrasarathe wants to merge 2 commits into
devfrom
fix/deposit-details-bugs
Open

fix(deposit): update Bridge SEPA account holder name + deposit details bugs#2417
kushagrasarathe wants to merge 2 commits into
devfrom
fix/deposit-details-bugs

Conversation

@kushagrasarathe

Copy link
Copy Markdown
Contributor

What

Batch of deposit-details bug fixes.

1. Bridge SEPA account holder name

Bridge completed a legal entity migration on 2026-06-27. Their EUR/GBP vIBANs now reflect the new entity name Bridge Building S.A. (previously Bridge Building Sp. Z.o.o.). Sending banks whose records still have the old name surface a name-mismatch warning; Banking Circle accepts payments to either name so transfers still process, but the mismatch confuses users.

Updated the FE fallback account holder name (BRIDGE_DEFAULT_ACCOUNT_HOLDER_NAME) to match the current legal entity.

Source: Bridge support (ticket #171111) confirmed the new entity name and that both names route correctly.

Notes

  • Only the fallback constant changed — it's rendered when Bridge omits account_holder_name on faster-payments deposit instructions.
  • Test fixtures (render-baseline.json) still carry the old name as mock server response inputs; left unchanged (not the display fallback).

More deposit-details fixes to follow in this PR.

Bridge completed a legal entity migration on 2026-06-27; EUR/GBP vIBANs now
reflect the new entity name 'Bridge Building S.A.' (was 'Bridge Building
Sp. Z.o.o.'). Update the FE fallback account holder name to match and avoid
sender name-mismatch confusion at deposit time.
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 78fbd634-89ed-47d3-9777-1fa177399819

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deposit-details-bugs

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
peanut-wallet Ready Ready Preview, Comment Jul 15, 2026 6:45am

Request Review

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 6186.26 → 6187.43 (+1.17)
Findings: -1 net (+6 new, -7 resolved)

🆕 New findings (6)

  • critical complexity — src/components/AddMoney/components/AddMoneyBankDetails.tsx — CC 82, MI 58.34, SLOC 149
  • high method-complexity — src/components/AddMoney/components/AddMoneyBankDetails.tsx:50 — AddMoneyBankDetails CC 32 SLOC 64
  • medium high-mdd — src/components/TransactionDetails/provider-rows/BridgeDepositInstructions.tsx:23 — BridgeDepositInstructions: MDD 104.1 (uses across many lines from declarations)
  • medium complexity — src/components/TransactionDetails/provider-rows/BridgeDepositInstructions.tsx — CC 16, MI 66.22, SLOC 14
  • medium complexity — src/constants/payment.consts.ts — CC 5, MI 62.49, SLOC 30
  • low high-dlt — src/components/AddMoney/components/AddMoneyBankDetails.tsx:50 — AddMoneyBankDetails: DLT 29 (calls 29 distinct functions — high context load)

✅ Resolved (7)

  • src/components/AddMoney/components/AddMoneyBankDetails.tsx — CC 83, MI 58.4, SLOC 148
  • src/components/AddMoney/components/AddMoneyBankDetails.tsx:50 — AddMoneyBankDetails CC 33 SLOC 63
  • src/components/TransactionDetails/provider-rows/BridgeDepositInstructions.tsx:23 — BridgeDepositInstructions: MDD 105.0 (uses across many lines from declarations)
  • src/components/TransactionDetails/provider-rows/BridgeDepositInstructions.tsx — CC 17, MI 66.76, SLOC 13
  • src/components/TransactionDetails/provider-rows/BridgeDepositInstructions.tsx:23 — BridgeDepositInstructions CC 15 SLOC 9
  • src/constants/payment.consts.ts — CC 2, MI 62.64, SLOC 22
  • src/components/AddMoney/components/AddMoneyBankDetails.tsx:50 — AddMoneyBankDetails: DLT 28 (calls 28 distinct functions — high context load)

📈 Painscore deltas (top movers)

File Before After Δ
src/constants/payment.consts.ts 5.4 6.1 +0.7

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • unit: 1936 ran, 0 failed, 0 skipped, 22.0s

📊 Coverage (unit)

metric %
statements 58.9%
branches 42.6%
functions 47.6%
lines 59.1%
⏱ 10 slowest test cases
time test
2.0s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › never places two stickers in heavy overlap (broad seed sweep)
0.8s src/utils/__tests__/demo-api.test.ts › isDemoMode() is false when not running under Capacitor
0.2s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › every sticker stays within canvas at any count
0.2s src/app/actions/__tests__/api-headers.test.ts › should include Content-Type in validateInviteCode
0.2s src/app/actions/__tests__/api-headers-extended.test.ts › should not include apiKey in validateInviteCode body
0.1s src/utils/__tests__/demo-balance.test.ts › keeps a spent-down balance across a cold start within the TTL
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle maximum length (17 digits) US account
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle valid 9-digit US account
0.1s src/components/Global/SupportDrawer/__tests__/SupportDrawer.test.tsx › shows the mailto fallback + retry when the proxy reports CRISP_FAILED
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle valid Italian IBAN
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

The old fix only touched the fallback constant, which the FE uses solely when
Bridge omits account_holder_name (GBP faster_payments). For EUR/SEPA Bridge
returns the field directly and can still send the stale 'Sp. Z.o.o.' name, so
the fallback never applied and the sender's Confirmation-of-Payee check kept
flagging a mismatch.

Route both display sites through resolveBridgeAccountHolderName, which maps the
stale/absent legacy name to the current entity ('Bridge Building S.A.') while
passing through any other value. Banking Circle accepts either name so payments
still settle — this just removes the name-mismatch warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant