chore: back-merge main → dev (manicero badge, pre SP-151 release)#2434
Conversation
FE half of the Manicero badge (Argentine superfan in-joke, IYKYK). Claimable by existing users via bare ?campaign=manicero link (vanity, no waitlist skip) and by new users via ?code=manicero invite flow. Art + copy from Konrad's pick in mono inbox/manicero-badge/.
Review finding: every sibling event badge has a UTM_CAMPAIGN_TO_BADGE_MAP alias; without it a ?utm_campaign=manicero link silently grants nothing. Also feeds PostHog's utm_* auto-capture for the campaign funnel.
feat(badges): add MANICERO badge asset + claim maps
The shared withdraw amount step applied getMinimumAmount() to every method; crypto has no country so it fell into the $1 default — blocking sub-$1 on-chain sends that send-via-link already allows. The minimum was introduced for bank offramps (295c8ec, Bridge's $1 floor) and crypto only inherited it by sharing the page. Bank rails keep their country minimums.
…m Rhino deposits Review findings on the initial cut: - The exemption keyed off the URL param independently of routing: a stale bank selectedMethod (app-wide context) entering via /withdraw?method=crypto got min=$0 while Continue still routed to the bank flow. The predicate now follows selectedMethod when set; the URL only covers the pre-effect frame. - Removing the blanket $1 floor exposed the cross-chain path to sub-minimum Rhino SDA deposits, which are accepted on-chain but never bridged (stranded, uncredited — known incident class). The confirm CTA now blocks below the route's minDepositLimitUsd, which the page previously discarded. - Consolidated the two other inline is-crypto checks onto the same predicate, stopped the exchange-rate poll when crypto is selected, dropped a vacuous test assertion.
…iat-min fix: exempt crypto withdrawals from the fiat $1 minimum
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code-analysis diffPainscore total: 6205.21 → 6206.68 (+1.47) 🆕 New findings (31)
…and 11 more. ✅ Resolved (31)
…and 11 more. |
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Clean back-merge (merge-tree probe: no conflicts) of the manicero-badge hotfixes (#2431) that landed on main after #2429. Keeps dev a superset of main before the SP-151 release PR merges. Release page: https://app.notion.com/p/peanutprotocol/prod-release-sp-151-39f83811757980f6bcc5c118239d4758
🤖 Generated with Claude Code