Update push_notification.rb#25
Open
muzammalaslam wants to merge 1 commit into
Open
Conversation
Default notification option change
Contributor
|
Hi @muzammalaslam , could you provide a little context regarding the reason behind this change? |
Author
|
Hi antillas21 <https://github.com/antillas21>,
There is an issue for sending push notification that if we don't want to
increase the badges for some push notifications like silent push its also
increase. I did alot of discussion with pushwoosh Support. They said that
its not there default behavior. Gem is not compatible. So, I change it
according to it and my issue is resolved.
Thanks,
Regards,
Muzammal Aslam
…On Thu, Jun 22, 2017 at 10:31 PM, Antonio Antillon ***@***.*** > wrote:
Hi @muzammalaslam <https://github.com/muzammalaslam> , could you provide
a little context regarding the reason behind this change?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALgATLMHpuSMiDRyuoaEuK71qCUeUYMKks5sGqTggaJpZM4OB368>
.
|
Contributor
|
Thanks for the clarification @muzammalaslam 😄 Does this look good to you @pedroandrade ? |
Owner
|
Sounds great @muzammalaslam and @antillas21 @muzammalaslam could you fix the spec? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default notification option change