v1.6.39 - #78
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps PeerHub to release v1.6.39 and applies frontend dependency updates intended as security maintenance, along with the usual version/documentation updates for a release.
Changes:
- Bump app version references to 1.6.39 (VERSION file + README badge) and add a 1.6.39 changelog entry.
- Update frontend dependency react-router from ^7.15.0 to ^8.3.0 and refresh the lockfile accordingly.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| VERSION | Updates the published version to 1.6.39. |
| README.md | Updates the README version badge to 1.6.39. |
| CHANGELOG.md | Adds the 1.6.39 release section noting a security update. |
| frontend/package.json | Bumps react-router to ^8.3.0. |
| frontend/package-lock.json | Lockfile updates reflecting the dependency bump (including updated engine/peer constraints). |
Files not reviewed (1)
- frontend/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
6338
to
+6342
| "engines": { | ||
| "node": ">=20.0.0" | ||
| "node": ">=22.22.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "react": ">=18", | ||
| "react-dom": ">=18" | ||
| "react": ">=19.2.7", |
Comment on lines
26
to
29
| "react": "^19.1.0", | ||
| "react-dom": "^19.1.0", | ||
| "react-router": "^7.15.0", | ||
| "react-router": "^8.3.0", | ||
| "zod": "^4.3.6" |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- frontend/package-lock.json: Generated file
Comments suppressed due to low confidence (1)
frontend/package.json:28
- After upgrading to react-router@8, keeping
@types/react-router(which targets older major versions) is likely to provide incorrect/duplicate typings. react-router ships its own TypeScript types, so this@typespackage should typically be removed to avoid type conflicts.
"react-router": "^8.3.0",
Comment on lines
26
to
+28
| "react": "^19.1.0", | ||
| "react-dom": "^19.1.0", | ||
| "react-router": "^7.15.0", | ||
| "react-router": "^8.3.0", |
Comment on lines
+57
to
+58
| node-version: "lts/*" | ||
| check-latest: true |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- frontend/package-lock.json: Generated file
Comments suppressed due to low confidence (2)
frontend/package.json:28
- react-router@^8.3.0 declares peer requirements for react/react-dom >=19.2.7, but package.json currently allows older versions via ^19.1.0, which can lead to peer dependency warnings or failed installs if a resolver picks 19.1.x. Also,
@types/react-routeris pinned to v5-era types and is very likely incompatible with react-router v8; react-router ships its own types, so keeping this package can cause incorrect typing.
"react": "^19.1.0",
"react-dom": "^19.1.0",
"react-router": "^8.3.0",
.github/workflows/ci.yml:60
- CI now uses node-version: "lts/*" which can drift over time. Since react-router@8.3.0 has an explicit engines requirement of Node >=22.22.0 (per package-lock.json), pinning the CI Node version to at least that minimum will avoid future CI breakage and makes the runtime requirement explicit.
with:
node-version: "lts/*"
check-latest: true
cache: npm
cache-dependency-path: frontend/package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
Validation
cd backend && uv lock --checkcd backend && uv run ruff check app testscd backend && uv run mypycd backend && uv run pytestcd frontend && npm run lintcd frontend && npm run test:runcd frontend && npm run buildChecklist
VERSION,CHANGELOG.md, andREADME.md.