Repository navigation
Android: launch switches in debug builds only - #619
Merged
Merged
Conversation
The activity is exported, so in a release build any app on the phone could start it with LARECOMP_* debug switches set. They are read only when the app is debuggable (the debug APKs installed over adb). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #617, suggested in review. The activity is exported, so in a release build any app on the phone could start LAS Recomp with
LARECOMP_*debug switches set as launch extras. They're now read only when the app is debuggable (ApplicationInfo.FLAG_DEBUGGABLE), which is what the debug APKs installed over adb are. Release builds ignore them.LASRecompActivity.java: the extras are read only in a debuggable build.docs/android.md: notes "debug builds only".Tested: the Java compiles (
compileDebugJavaWithJavac). Desktop builds are unaffected.🤖 Generated with Claude Code