Repository navigation
Run the cli-app fixture when it is invoked through its installed bin link - #31
Merged
Merged
Conversation
…link bin/slugify.js ran only when argv[1] ended in slugify.js, so the slugify command an install creates printed nothing. Compare the real path of argv[1] with the module's own path instead. Found while fixing #24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The
cli-appbenchmark fixture now prints its slug when it runs through theslugifycommand an install creates, not only when invoked asnode bin/slugify.js.Why
bin/slugify.jsguarded its main block withprocess.argv[1]?.endsWith('slugify.js'). An npm install linksslugifyto the file, soargv[1]ends inslugifyand the command exited 0 with no output. A README that correctly documentsnpm install --global .andslugify "Hello, World!"(#24) described a command that did nothing. The guard now compares the real path ofargv[1]with the module's own path.Checks
node --test tests/repository.test.mjspassesnode --test tests/evals/*.test.mjspassestest/cli.test.jspasses (3/3) — importingrunstill prints nothingnode bin/slugify.js "Hello, World!"→hello-world; through a symlink namedslugify,--sep _ "Hello, World!"→hello_worldCHANGELOG.md— not updated; benchmark test data, no change to the skill