Special case 'union square' libpostal parse#1509
Merged
orangejulius merged 1 commit intomasterfrom Feb 5, 2021
Merged
Conversation
While also a neighbourhood, most data for places called 'Union Square' are actually in the `venue` layer, so it's generally better to allow this query to hit Elasticsearch and return venues.
orangejulius
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While also a neighbourhood, most data for places called 'Union Square' are actually in the
venuelayer, so it's generally better to allow this query to hit Elasticsearch and return venues.This change will only affect the search endpoint, and in acceptance test testing, it doesn't have any impact without other incoming PRs, like #1506.