refactor: use ESLint & Prettier instead of jshint#1593
Open
vinayakkulkarni wants to merge 4 commits intopelias:masterfrom
Open
refactor: use ESLint & Prettier instead of jshint#1593vinayakkulkarni wants to merge 4 commits intopelias:masterfrom
jshint#1593vinayakkulkarni wants to merge 4 commits intopelias:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
Here's the reason for this change 🚀
Instead of jshint, I added support for
prettier&ESLintHere's what actually got changed 👏
Nothing as such, the source code is same but formatting is standardised
Here's how others can test the changes 👀
npm run lint:eslint# Checks with ESLintnpm run lint:eslint:fix# Fixes all issues with ESLintnpm run lint:prettier# Checks with Prettiernpm run lint:prettier:fix#Fixes all issues with PrettierRef Issue – pelias/pelias#922
Ref PR – #1579