Skip to content

Made pint - #2

Merged
JoanFo1456 merged 1 commit into
mainfrom
upload-everything
Dec 25, 2025
Merged

JoanFo1456 merged 1 commit into
mainfrom
upload-everything

Conversation

@JoanFo1456

@JoanFo1456 JoanFo1456 commented Dec 25, 2025 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Style
    • Code formatting improvements for consistency and maintainability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 25, 2025 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Whitespace normalization across two PHP files removes extraneous spaces after the logical negation operator in conditional statements, aligning code formatting without altering functionality or control flow.

Changes

Cohort / File(s) Change Summary
Whitespace Normalization in Conditional Checks
starrynight/src/Providers/StarryNightPluginProvider.php, starrynight/src/StarryNightPlugin.php
Removed spaces after logical negation operator (!) in conditional statements. Changed if (! File::exists(...)) to if (!File::exists(...)) and if (! File::isDirectory(...)) to if (!File::isDirectory(...)). No logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 With whiskers twitching, I hop through the code,
Spaces that lingered? No more! Cleaned the road.
The ! stands tall, no gap by its side,
Formatting's prettier—logic's unchanged, I've tried!
A tidy pull request, neat as can be,
Our PHP shines now, as clean as can see! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title 'Made pint' is vague and does not accurately describe the actual changes in the pull request, which are formatting/whitespace improvements. Use a more descriptive title that reflects the actual changes, such as 'Fix PHP code formatting by normalizing negation operator spacing' or similar.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upload-everything

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3d11fe4 and 6ecd5ea.

📒 Files selected for processing (2)
  • starrynight/src/Providers/StarryNightPluginProvider.php
  • starrynight/src/StarryNightPlugin.php
🧰 Additional context used
🪛 GitHub Actions: Lint
starrynight/src/Providers/StarryNightPluginProvider.php

[error] 1-1: Pint: style issue detected in provider file (not_operator_with…).

starrynight/src/StarryNightPlugin.php

[error] 1-1: Pint: style issue detected in plugin file (braces_position, not_operator_with…).

🔇 Additional comments (3)
starrynight/src/StarryNightPlugin.php (2)

26-28: LGTM! Whitespace normalization applied correctly.

The removal of spaces after the ! operator aligns with PHP style conventions.


148-160: The recommended Pint command won't work in this repository.

Pint is not installed as a composer dependency (no composer.json exists). The lint workflow downloads Pint as a PHAR file instead. Use curl -fsSL -o pint.phar https://github.com/laravel/pint/releases/latest/download/pint.phar && chmod +x pint.phar && php pint.phar to check or fix style violations, or add Pint as a composer dev dependency.

Likely an incorrect or invalid review comment.

starrynight/src/Providers/StarryNightPluginProvider.php (1)

37-39: Good formatting improvements, but pipeline still failing.

The whitespace normalization removing spaces after the ! operator is correct and aligns with common PHP style conventions.

However, the pipeline is still reporting style issues. Consider running Pint automatically to fix all remaining style issues in one pass rather than making manual fixes:

./vendor/bin/pint

This will ensure all style violations are addressed consistently across the codebase.


Comment @coderabbitai help to get the list of available commands and usage tips.

@JoanFo1456
JoanFo1456 merged commit fc92473 into main Dec 25, 2025
1 of 13 checks passed
@JoanFo1456
JoanFo1456 deleted the upload-everything branch December 25, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant