Skip to content

Check exit code of install script #88

Description

@Boy132

Currently wings ignores the output of the install script itself and returns a "successfull" install even if an error happened. Ideally it should check for any errors happening when running the install script and/ or check the exit code of the script.
If possible the error message and the exit code should be reported back to the panel so we can display that on the frontend.

https://github.com/pelican-dev/wings/blob/b0d18ecd7631b2c51754e9ec78c406d91a9a64bb/server/install.go#L500-L503
https://github.com/pelican-dev/wings/blob/b0d18ecd7631b2c51754e9ec78c406d91a9a64bb/server/install.go#L54

Test case: set the install script of an egg to exit 1, setup a server with this egg and trigger an install. Wings will return the installation as "successfull" while it should be "failed".

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions