Issue 1970: Implement Project Auto-Save by Assemberist · Pull Request #1999 · pencil2d/pencil

Assemberist · 2026-04-03T19:53:33Z

Implementation of autoSave feature.

Never auto-save to the original .pclx/.pcl file - User's file remains untouched
Auto-save only to working directory - Temporary, session-specific location
Explicit user approval required to apply auto-saved changes to original file
~~Clear indication when recovered project differs from saved file~~
User control over auto-save interval and enable/disable

Indication wasn't implemented. Below how the new class works

MrStevns

Hi Assemberist

Thanks for contributing to the project.

Based on the discussions between you and Chchwy in #1970, the logic seems fine to me, so I am not going to comment much on that.

This review is solely focused on the coding practices.
As of right now, the PR does not conform to our way of coding. This will need to be addressed before it can be approved on that account.

MrStevns

Good job, we're getting there.

The latest changes looks better but you seem to have forgotten some things I mentioned the first time around.

btw. remember to re-request a review when you've made the appropriate changes, so it's clearer to the reviewer (me) that it can be looked at again 🙂

MrStevns

Style wise it looks good to me now.
Now we just await what @chchwy says about the functionality 🙂

- Add AutosaverByTime class for timer-based auto-save to working folder - Add AUTO_SAVE_BY_TIME and AUTO_SAVE_BY_TIME_TIMER settings - Update preferences UI with time-based auto-save controls - Update both CMake and qmake build systems (fix: PR missed CMake) - Fix: pass parent to AutosaverByTime to prevent memory leak - Fix: use stateChanged signal for Qt <6.7 compatibility - Fix: keep recoverables.empty() early-return guard Agent-Logs-Url: https://github.com/pencil2d/pencil/sessions/40216fd4-b315-4426-b20c-9ed8a05ba705 Co-authored-by: chchwy <163800+chchwy@users.noreply.github.com>

Assemberist · 2026-04-13T14:22:57Z

Hi, it looks like i'm using newer development kit.
My setup:

Qt Creator 18.0.1
Based on Qt 6.10.1 (GCC 15.2.1 20251112, x86_64)

It compiles project with my changes, but show this kind of warnings
pencil/app/src/toolspage.cpp:30: warning: ‘void QCheckBox::stateChanged(int)’ is deprecated: Use checkStateChanged() instead [-Wdeprecated-declarations]
I'll try to configure my setup and recheck.

chchwy · 2026-04-15T11:59:53Z

We currently use both Qt 5.15 & 6.5.3. I would recommend you install Qt 6.5.3 for pencil2d development.

Hi, it looks like i'm using newer development kit. My setup:
Qt Creator 18.0.1
Based on Qt 6.10.1 (GCC 15.2.1 20251112, x86_64)
It compiles project with my changes, but show this kind of warnings pencil/app/src/toolspage.cpp:30: warning: ‘void QCheckBox::stateChanged(int)’ is deprecated: Use checkStateChanged() instead [-Wdeprecated-declarations] I'll try to configure my setup and recheck.

Assemberist · 2026-04-18T09:49:09Z

We currently use both Qt 5.15 & 6.5.3. I would recommend you install Qt 6.5.3 for pencil2d development.
Hi, it looks like i'm using newer development kit. My setup:
Qt Creator 18.0.1
Based on Qt 6.10.1 (GCC 15.2.1 20251112, x86_64)
It compiles project with my changes, but show this kind of warnings pencil/app/src/toolspage.cpp:30: warning: ‘void QCheckBox::stateChanged(int)’ is deprecated: Use checkStateChanged() instead [-Wdeprecated-declarations] I'll try to configure my setup and recheck.

Hi,
I'll try, but it's difficult since i use archlinux. About this pull request: i can see #2000, where checkStateChanged() was fixed. Should i proceed with code modification?
BRs.

Added 2 Settings to preferences->files 1. autosaving by time 2. autosave timer (min) Defects: Autosaving can break user action. Need implement check if user do some input before autosave.

Found assumed save function. Saving ocurred when user don't draw something (don't hold a mouse button or a modificator-keys i.e. SHIFT)

Apply project styles

Allman style is used public interfaces should be top.

To Null pointer Co-authored-by: Oliver Stevns <1045397+MrStevns@users.noreply.github.com>

add explicit

sonarqubecloud · 2026-04-18T10:47:47Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chchwy · 2026-04-19T08:08:07Z

We currently use both Qt 5.15 & 6.5.3. I would recommend you install Qt 6.5.3 for pencil2d development.
Hi, it looks like i'm using newer development kit. My setup:
Qt Creator 18.0.1
Based on Qt 6.10.1 (GCC 15.2.1 20251112, x86_64)
It compiles project with my changes, but show this kind of warnings pencil/app/src/toolspage.cpp:30: warning: ‘void QCheckBox::stateChanged(int)’ is deprecated: Use checkStateChanged() instead [-Wdeprecated-declarations] I'll try to configure my setup and recheck.
Hi, I'll try, but it's difficult since i use archlinux. About this pull request: i can see #2000, where checkStateChanged() was fixed. Should i proceed with code modification? BRs.

Yes, please.

chchwy · 2026-04-19T11:29:18Z

I will send you a PR to address issues

github-project-automation bot added this to Pull Request Priority Apr 3, 2026

github-project-automation bot moved this to Needs Review in Pull Request Priority Apr 3, 2026

Assemberist mentioned this pull request Apr 3, 2026

Implement Project Auto-Save #1970

Open

MrStevns requested changes Apr 4, 2026

View reviewed changes

github-project-automation bot moved this from Needs Review to Waiting for Requested Changes in Pull Request Priority Apr 4, 2026

chchwy self-requested a review April 6, 2026 11:14

chchwy added this to the 0.8.0 milestone Apr 6, 2026

MrStevns requested changes Apr 6, 2026

View reviewed changes

Assemberist requested a review from MrStevns April 6, 2026 18:30

MrStevns reviewed Apr 8, 2026

View reviewed changes

Comment thread core_lib/src/util/autosaverbytime.h Outdated

Comment thread app/src/mainwindow2.h Outdated

Assemberist requested a review from MrStevns April 8, 2026 23:31

MrStevns approved these changes Apr 9, 2026

View reviewed changes

github-project-automation bot moved this from Waiting for Requested Changes to Approved in Pull Request Priority Apr 9, 2026

Copilot AI mentioned this pull request Apr 13, 2026

Implement auto-save by time with fixes for memory leak, CMake build, and Qt compatibility #2000

Closed

Assemberist and others added 6 commits April 18, 2026 18:44

Issue 1970: Implement Project Auto-Save

1225c83

Added 2 Settings to preferences->files 1. autosaving by time 2. autosave timer (min) Defects: Autosaving can break user action. Need implement check if user do some input before autosave.

Issue 1970: Implement Project Auto-Save

34674b9

Found assumed save function. Saving ocurred when user don't draw something (don't hold a mouse button or a modificator-keys i.e. SHIFT)

Issue 1970: Implement Project Auto-Save

0e18f3f

Apply project styles

Issue 1970: Implement Project Auto-Save

1a5e3c6

Allman style is used public interfaces should be top.

Issue 1970: Implement Project Auto-Save

745abe0

To Null pointer Co-authored-by: Oliver Stevns <1045397+MrStevns@users.noreply.github.com>

Issue 1970: Implement Project Auto-Save

d080637

add explicit

chchwy force-pushed the master branch from 9c23250 to d080637 Compare April 18, 2026 10:44

Conversation

Assemberist commented Apr 3, 2026

Uh oh!

MrStevns left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MrStevns left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MrStevns left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Assemberist commented Apr 13, 2026

Uh oh!

chchwy commented Apr 15, 2026

Uh oh!

Assemberist commented Apr 18, 2026

Uh oh!

sonarqubecloud bot commented Apr 18, 2026

Quality Gate passed

Uh oh!

chchwy commented Apr 19, 2026

Uh oh!

chchwy commented Apr 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MrStevns left a comment •

edited

Loading

MrStevns left a comment •

edited

Loading

MrStevns left a comment •

edited

Loading