Add Roland JV-1080 and NRPNs for JV-1010#209
Open
mataspetrikas wants to merge 2 commits intopencilresearch:mainfrom
Open
Add Roland JV-1080 and NRPNs for JV-1010#209mataspetrikas wants to merge 2 commits intopencilresearch:mainfrom
mataspetrikas wants to merge 2 commits intopencilresearch:mainfrom
Conversation
Author
|
hey @pencilresearch - I read about your project on HN today, really cool stuff that you are gathering the data for all those boxes in an accesssible/usable form! Pls check this PR and let me know if you think it makes sense - I wanted to expand a bit on the Roland boxes I have worked in the past. |
Collaborator
|
Sorry for the delay in reviewing your PR. Thanks a lot for the solid contribution! Especially for filling in the JV-1010 definition. I'm not that familiar with Roland GS so I'm just going off the manuals:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Roland/JV-1080.csvwith the full CC list and standard Roland GS NRPNs (vibrato, TVF, envelope, drum part)Roland/JV-1010.csvwith the same NRPNs, which were previously missingThe JV-1080 and JV-1010 share the same sound engine and MIDI implementation, so both files now reflect the complete set of CC and NRPN parameters supported by the hardware.
Test plan