-
Notifications
You must be signed in to change notification settings - Fork 1
Release v 1.2 #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release v 1.2 #197
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c3c1724
Added BC groupings functionality
pendingintent 72d9a26
Issue #192: Cleaned document directories
pendingintent 5cd13f4
Merge branch 'biomedical-concept-grouping' into release-v-1.2
pendingintent 76a2670
Issue #188: Added new sidebar navigation with expandable submenus
pendingintent 811a8e1
Initial commit of Markdown and HTML help files
pendingintent 17ef8f2
Consolidated images for Markdown and HTML help pages
pendingintent cf94418
Issue #194: Removed auto-mapping from DSS to allow user to select mul…
pendingintent 67e310f
Biomedical concept properties and data element concepts are now displ…
pendingintent 518da4e
Synthentic collected data to support NCT01797120
pendingintent 2360e44
DSS are no longer used to populate BiomedicalConceptProperty values
pendingintent 6bcd1e5
Fixed stale alias codes/codes in database and added code to prevent c…
pendingintent 36ae840
Added bc surrogate export to UI
pendingintent d3017e9
Added CDISC SDTM Controlled Terminology Browser
pendingintent 8f936c6
Added CDISC CDASH Controlled Terminology Browser
pendingintent bd2039c
Added define-xml controlled terminology browser
pendingintent 26875a7
Protocol terminology now added via CDISC Library API. List of ARM ty…
pendingintent 432ef09
DDF controlled terminology now added via CDISC Library API. List of …
pendingintent 19854d6
Addressed multiple security issues
pendingintent 234b3fb
Fixed dependency requirements for the test suite
pendingintent 2439c2e
Added text to indicate DSS mapping is optional
pendingintent 2b9b71f
Added jinja2 to pyproject.toml
pendingintent c760af3
Merge branch 'pendingintent-fix-dependencies' into release-v-1.2
pendingintent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| # Changelog: biomedical-concept-grouping | ||
|
|
||
| **Branch:** `biomedical-concept-grouping` | ||
| **Base commit:** `60ce0d1` | ||
|
|
||
| --- | ||
|
|
||
| ## New Feature: Biomedical Concept Groups | ||
|
|
||
| Introduces a global grouping mechanism for biomedical concepts. Groups are | ||
| not SoA-specific — once created they can be associated with activities in | ||
| any SoA. | ||
|
|
||
| ### Database Migrations (`migrate_database.py`) | ||
|
|
||
| - `_migrate_add_concept_group_table()` — creates two new tables: | ||
| - `concept_group` — stores `concept_group_uid`, `name`, `label`, | ||
| `description` | ||
| - `concept_group_concept` — stores the many-to-many relationship between | ||
| a group and its assigned concept codes | ||
| - `_migrate_activity_concept_add_concept_group_uid()` — adds | ||
| `concept_group_uid` column to `activity_concept` | ||
| - `_migrate_surrogate_add_concept_group_uid()` — adds `concept_group_uid` | ||
| column to `biomedical_concept_surrogate` | ||
|
|
||
| ### New Router (`routers/concept_groups.py`) | ||
|
|
||
| Full CRUD for concept groups, including: | ||
| - Create, read, update, delete concept groups (API + UI endpoints) | ||
| - Assign / unassign individual concept codes to a group | ||
| - Link a concept group to an activity (applies all group concepts at once) | ||
|
|
||
| ### New Template (`templates/concept_groups.html`) | ||
|
|
||
| Management page for concept groups — create groups, assign concepts, and | ||
| view group membership. | ||
|
|
||
| ### `app.py` | ||
|
|
||
| - Imports and runs the three new migration functions at startup | ||
| - Registers `concept_groups_router` (both API and UI routers) | ||
| - `_get_activity_concepts()` updated to `LEFT JOIN concept_group` and | ||
| return `concept_group_uid` and `group_name` alongside existing fields | ||
| - New `_get_concept_groups_for_cell()` helper used when rendering the | ||
| concepts cell partial | ||
|
|
||
| ### Updated Router: `routers/activities.py` | ||
|
|
||
| - `ui_list_activities` query branches updated to `LEFT JOIN concept_group` | ||
| when the `concept_group_uid` column is present | ||
| - `concept_group_uid` and `group_name` included in the per-activity concept | ||
| dict | ||
| - `concept_groups` list fetched globally and passed to the template context | ||
|
|
||
| ### Updated Router: `routers/bc_surrogates.py` | ||
|
|
||
| - `_render_concepts_cell` updated to detect the `concept_group_uid` column | ||
| and include `concept_group_uid` / `group_name` in `selected_list` | ||
|
|
||
| ### Updated Templates | ||
|
|
||
| - `templates/activities.html` — computes `activity_group_uids` (unique | ||
| group UIDs currently assigned to the activity) for use inside the | ||
| `concepts_cell.html` include | ||
| - `templates/base.html` — adds **Biomedical Concept Groups** navigation | ||
| link; reorders BC-related nav items (Concepts → Categories → Groups → | ||
| SDTM Specializations) | ||
| - `templates/concepts_cell.html` — updated to display assigned concept | ||
| groups, render group badges, and expose group-assignment controls via | ||
| HTMX | ||
|
|
||
| --- | ||
|
|
||
| ## CI / Tooling | ||
|
|
||
| ### `pyproject.toml` | ||
|
|
||
| - Added `pytest-cov>=4.0.0` to the `[dev]` optional dependencies so | ||
| coverage reporting works in local and CI environments. | ||
|
|
||
| ### `.github/workflows/ci.yml` | ||
|
|
||
| - Added `# yaml-language-server: $schema=…` modeline to pin the GitHub | ||
| Actions schema and suppress false-positive CDISC schema diagnostics | ||
| from the VS Code YAML extension. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.