Repository navigation
Fix qBittorrent 5.2.0 authentication failure (HTTP 204 on login) - #170
Merged
pennydreadful merged 1 commit intoSep 10, 2026
Merged
Conversation
Collaborator
|
@pennydreadful This pr looks good. Any concerns? |
2 tasks done
3n8
pushed a commit
to 3n8/bookshelf
that referenced
this pull request
Aug 27, 2026
qBittorrent 5.2.0+ returns 204 No Content on successful /api/v2/auth/login instead of 200 with body "Ok.". Treat empty bodies as success and map HTTP 401 to an authentication error, matching Sonarr/Radarr. Also publish images as ghcr.io/3n8/bookshelf and grant the CI token the permissions a fork needs to push packages. Fixes pennydreadful#160, pennydreadful#165, pennydreadful#178 (unmerged upstream PRs pennydreadful#158, pennydreadful#162, pennydreadful#170).
qBittorrent 5.2.0 changed /api/v2/auth/login to return 204 No Content on success instead of 200 with "Ok." in the body, so successful logins were being treated as authentication failures. Accept an empty response body as success, matching the fix already applied in Sonarr and Radarr. Fixes pennydreadful#160
pennydreadful
force-pushed
the
fix/qbittorrent-520-login
branch
from
September 10, 2026 17:36
c66de26 to
0c99803
Compare
pennydreadful
enabled auto-merge (squash)
September 10, 2026 17:49
pennydreadful
disabled auto-merge
September 10, 2026 17:49
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qBittorrent 5.2.0 changed
/api/v2/auth/loginto return204 No Contentwith an empty body on successful login, instead of200withOk.. The auth check inQBittorrentProxyV2treats anything that isn'tOk.as a failure, so valid credentials are rejected with "Authentication failure" even though qBittorrent logs the login as successful.This migrates the same one-line fix Sonarr and Radarr already applied for this change: treat an empty response body as success. Bad logins are unaffected — they still return a non-empty
Fails.body (older versions) or a 401/403 (5.2.0), both of which are still rejected.Tested against qBittorrent 5.2.0: download client test and add now succeed.
Fixes #160