Next.js: extract page routes (app/page.tsx, pages/*.tsx)#6
Merged
jorgeraad merged 1 commit intocursor/add-kind-field-4943from Apr 29, 2026
Merged
Conversation
Extend the Next.js extractor to discover user-visible page routes:
App Router:
- Scan app/**/page.{tsx,jsx,ts,js} files
- Emit as { method: 'GET', handler: 'Page', kind: 'page' }
- Exclude layout files (layout, template, loading, error, not-found, default)
Pages Router:
- Scan pages/**/*.{tsx,jsx,ts,js} files
- Exclude pages/api/ (already handled as API endpoints)
- Exclude special files (_app, _document, _error, _middleware)
- Normalize /index segments (pages/about/index.tsx -> /about)
Also adds test fixture and 21 tests covering all extraction scenarios.
Co-authored-by: Jorge Alejandro Raad <jorge@pensarai.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issue.
Reviewed by Cursor Bugbot for commit 062b4ec. Configure here.
| // Skip special Next.js files | ||
| if (PAGES_ROUTER_SPECIAL_FILES.has(stem)) continue; | ||
| // Skip layout-like files in pages router | ||
| if (APP_ROUTER_LAYOUT_FILES.has(stem)) continue; |
There was a problem hiding this comment.
App Router exclusions incorrectly applied to Pages Router
Low Severity
The APP_ROUTER_LAYOUT_FILES set (layout, template, loading, error, not-found, default) is applied to filter Pages Router files, but these are only reserved names in the App Router. In Pages Router, files like pages/error.tsx or pages/loading.tsx are perfectly valid pages (only _error.tsx with underscore is special). This causes legitimate Pages Router pages with these stems to be silently excluded from extraction results, including in nested paths like pages/dashboard/loading.tsx.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 062b4ec. Configure here.
jorgeraad
added a commit
that referenced
this pull request
Apr 29, 2026
* feat: add kind field (api | page | action | websocket) to EndpointInfo - Add EndpointKind type to types.ts - Add required kind field to EndpointInfo interface - Add optional kind? parameter to endpoint() factory (defaults to 'api') - Set kind: 'action' in server-actions extractor - Set kind: 'websocket' for FastAPI websocket routes - Include kind in JSON/NDJSON output for both map and impact formatters - Export EndpointKind from public API (index.ts) Co-authored-by: Jorge Alejandro Raad <jorge@pensarai.com> * feat(nextjs): extract page routes from app/ and pages/ directories (#6) Extend the Next.js extractor to discover user-visible page routes: App Router: - Scan app/**/page.{tsx,jsx,ts,js} files - Emit as { method: 'GET', handler: 'Page', kind: 'page' } - Exclude layout files (layout, template, loading, error, not-found, default) Pages Router: - Scan pages/**/*.{tsx,jsx,ts,js} files - Exclude pages/api/ (already handled as API endpoints) - Exclude special files (_app, _document, _error, _middleware) - Normalize /index segments (pages/about/index.tsx -> /about) Also adds test fixture and 21 tests covering all extraction scenarios. Co-authored-by: Cursor Agent <cursoragent@cursor.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the Next.js extractor to discover user-visible page routes that were previously missing from extraction output. The extractor now scans both App Router and Pages Router page files in addition to the existing API route scanning.
Changes
App Router pages (
app/**/page.{tsx,jsx,ts,js})app/andsrc/app/directories forpage.{tsx,jsx,ts,js}files{ method: "GET", handler: "Page", kind: "page" }app/blog/[slug]/page.tsx→/blog/[slug])layout,template,loading,error,not-found,defaultPages Router pages (
pages/**/*.{tsx,jsx,ts,js})pages/andsrc/pages/directoriespages/api/(already handled as API endpoints)_app,_document,_error,_middleware/indexsegments:pages/about/index.tsx→/about,pages/index.tsx→/{ method: "GET", handler: "Page", kind: "page" }Test coverage
nextjs-pagesfixture with realistic App Router + Pages Router structure[slug])/indexnormalization_app,_document, andapi/directoryOther
scripts/fixturestotsconfig.jsonexclude list (fixture TSX files don't have React types)Depends on
cursor/add-kind-field-4943(thekindfield onEndpointInfo)