Open
Conversation
wjbeau
requested review from
fmsouza and
yasincaliskan
and removed request for
fmsouza
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds support for ARC60 (SIWA / CAIP122 compatible auth signing requests). To enable this we will have to publish a new version of pera-connect (PR incoming there also). Tested with a custom version of our demo dapp since no ecosystem dapps support it yet because Pera doesn't.
Arbitrary data signing was broken somehow because it was partially integrated into the signing flow. So as not to create even more confusion, this PR also just completes the integration of data signing into the signing pipeline for both arbitrary data signing and arc 60
Related Issues
Closes https://algorandfoundation.atlassian.net/browse/PERA-3638
Checklist
Additional Notes