Open
Conversation
This change intorduces refactoring of all tools to work with new config implementation.
svetasmirnova
requested changes
Mar 31, 2026
Collaborator
svetasmirnova
left a comment
svetasmirnova
left a comment
There was a problem hiding this comment.
Please finish the merge of 3.x and resolve conflicts: pt-k8s-debug-collector tests fail.
svetasmirnova
requested changes
Mar 31, 2026
Collaborator
svetasmirnova
left a comment
svetasmirnova
left a comment
There was a problem hiding this comment.
pt-mongodb-summary test also fails. Looks like another conflict issue:
=== RUN TestGetMongosInfo
main_test.go:296:
Error Trace: /home/sveta/src/percona/percona-toolkit/src/go/pt-mongodb-summary/main_test.go:296
Error: Should not be: 0
Test: TestGetMongosInfo
--- FAIL: TestGetMongosInfo (0.00s)
Collaborator
This is not right. |
svetasmirnova
approved these changes
Apr 2, 2026
svetasmirnova
requested changes
Apr 2, 2026
|
|
||
| Disable update checks. | ||
|
|
||
| ``--version`` |
Collaborator
There was a problem hiding this comment.
Suggested change
| ``--version`` | |
| ``--version-check`` | |
| Check for updates (enabled by default). | |
| ``--no-version-check`` | |
| Disable update checks. | |
Collaborator
There was a problem hiding this comment.
- No need to mention --skip-pod-summary two times.
- Spaces matter, because they change formatting. Please follow style.
Comment on lines
+19
to
+22
| ``--config`` | ||
|
|
||
| List of Percona Toolkit configuration file(s) separated by a comma without an equal sign. Must be a first flag. Uses default config file locations if not specified. | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| ``--config`` | |
| List of Percona Toolkit configuration file(s) separated by a comma without an equal sign. Must be a first flag. Uses default config file locations if not specified. | |
| ``--config`` | |
| List of Percona Toolkit configuration file(s) separated by a comma without an equal sign. Must be a first flag. Uses default config file locations if not specified. | |
Collaborator
There was a problem hiding this comment.
Spaces affect formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates CLI/config handling to the new Kong-based configuration layer across all affected Go tools.
The goal is to standardize flag parsing, config-file behavior, password prompts, and version/version-check flow using shared config primitives.
Changes
kong.VersionFlaginlib/config/commonFlags.go.config.Setup(...)in:pt-mongodb-index-checkpt-mongodb-query-digestpt-mongodb-summarypt-pg-summarypt-secure-collectgetopt/kingpin) with Kong struct tags and hooks (AfterApply, commandRunmethods).config.VersionCheckFlag+versioncheck.CheckUpdates(...).config.StdinRequestStringfor DB/encryption passwords.pt-secure-collectsubcommands (collect,encrypt,decrypt,sanitize) to command structs with explicit validation and runtime handlers.Notes
This is primarily a CLI/config refactor; no intended functional changes in business logic.
Main expected impact is behavior consistency across tools (flags, defaults, help/version output, password prompts).
The contributed code is licensed under GPL v2.0
Contributor Licence Agreement (CLA) is signed
util/update-modules has been ran
Documentation updated
Test suite update