Sync CI dependencies with the PGDG packages #473
Conversation
PostgreSQL 18 introduces liburing (already installed), libnuma and libcurl as new optional depednencies so install them.
Right now we do not compile pplpython but we probably should. The Debian package from PGDG has this as a dependency.
Github's images alreayd had jq installed but when I used an image from Incus I had to manually install it so add it to the list of dependencies.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (59.68%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
+ Coverage 59.66% 59.68% +0.01%
==========================================
Files 67 67
Lines 10481 10481
Branches 1809 1809
==========================================
+ Hits 6254 6256 +2
+ Misses 3532 3530 -2
Partials 695 695
🚀 New features to boost your workflow:
|
|
I've been thinking about going in the completely opposite direction and remove everything that's already listed as installed on the runner image here: https://github.com/actions/runner-images/blob/ubuntu24/20251112.124/images/ubuntu/Ubuntu2404-Readme.md I'm not sure which approach is best, but we should choose one of them instead of being in the middle as we currently are. |
|
My thought was that going this direction would mean fewer manual calls and easier to maintain, but it is hard to predict. |
Hmm... What do we do with packages like wget for example that we install unnecessarily that's not part of the pgdg list? should we add all such packages even if they're already installed in the runner? I was thinking "install what we need that's not already installed" would lead to fewer manual calls and easier to maintain. But I might be wrong. When I wrote this on my "todo at some point in the future" list I didn't even consider copying the pgdg list at all to be clear. I now think that maybe we should copy the pgdg list verbatim as in this commit, but for everything outside of that list it's "if we need it and it's not already installed on the runner" maybe? |
That sounds like an appealing alternative which would mean no |
We just need to check if the same script is used in the QA jenkins though, since they probably use a pure ubuntu come to think of it. |
I have now verified that they don't use the script. |
| # Setup | ||
| jq | ||
| wget | ||
| # Build |
There was a problem hiding this comment.
Clearly label the where the list is copied from here, so it doesn't start diverging again in the future and anyone can see where to go look for an updated list if stuff starts failing.
3 participants
Try to keep use reasonably in sync with the Debian packages from PGDG. We do not use all these dependencies yet but maybe we should make sure we build with plpython, plperl, etc. But that is for another PR.
The list of build dependencies from the Debian package are the following:
And a diff is the following: