ci: fix CLI-branch injection env var typo (BRNACH → BRANCH)#586
Merged
Conversation
The 'Set up @percy/cli from git' step set BRNACH but the git clone reads $BRANCH, so on a workflow_dispatch run $BRANCH was empty and `git clone --branch ""` failed — CLI-branch regression never actually ran. Part of PER-9772. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pranavz28
marked this pull request as ready for review
June 29, 2026 11:48
Shivanshu-07
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
Set up @percy/cli from gitstep intest.ymlsets env varBRNACH(typo) but the clone reads$BRANCH:So on a
workflow_dispatchrun,$BRANCHis empty andgit clone --branch ""fails — CLI-branch regression for this SDK never actually ran. One-character fix:BRNACH→BRANCH.Why
Part of PER-9772 (run SDK regression against an unpublished
@percy/clibranch). This SDK looked injection-capable but was silently broken.Safety
No behavior change beyond fixing the var name.
branchis still env-passed and validated by the existing regex-match step before this step runs.Test plan
workflow_dispatchwith a known@percy/clibranch → clone/build/link succeeds andnpx percy --versionreflects the branch.🤖 Generated with Claude Code