docs: fix Android statusBarHeight default in README (80 → 120)#12
Open
Sriram567 wants to merge 1 commit into
Open
docs: fix Android statusBarHeight default in README (80 → 120)#12Sriram567 wants to merge 1 commit into
Sriram567 wants to merge 1 commit into
Conversation
README still documented the old 80 px Android status-bar default while 1.0.0 ships 120 (bumped in #9). Aligns the PERCY_STATUS_BAR_HEIGHT table row with the shipped default and updates the rationale. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The README's
PERCY_STATUS_BAR_HEIGHTrow documented the old Android default of80, but1.0.0ships120(bumped in #9). This corrects the documented default and rationale so docs match the shipped behaviour.Why it matters
The
1.0.0tarball on npm shipped this stale doc — a customer reading the README would expect80px masking while the SDK actually applies120. One-line table fix (plus updated rationale).Note
This corrects
maingoing forward; the README inside the already-published1.0.0npm tarball is immutable and stays as-is until the next publish.🤖 Generated with Claude Code