Skip to content

ci: expose built percy on PATH in CLI-branch injection (PER-9772) #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranavz28 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: expose built percy on PATH in CLI-branch injection (PER-9772) #38

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
345255c
ci: expose built percy on PATH in CLI-branch injection
pranavz28 Jun 28, 2026
fdd79e2
ci: pass CLI branch via env, not inline (fixes semgrep run-shell-inje…
pranavz28 Jun 29, 2026
c6fc704
Merge branch 'main' into PER-9772_fix-cli-branch-injection
pranavz28 Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,25 @@ jobs:
- run: yarn
- name: Set up @percy/cli from git
if: ${{ github.event_name == 'workflow_dispatch' }}
env:
BRANCH: ${{ github.event.inputs.branch }}
run: |
cd /tmp
git clone --branch ${{ github.event.inputs.branch }} --depth 1 https://github.com/percy/cli
git clone --branch "$BRANCH" --depth 1 https://github.com/percy/cli
cd cli
PERCY_PACKAGES=`find packages -mindepth 1 -maxdepth 1 -type d | sed -e 's/packages/@percy/g' | tr '\n' ' '`
git log -1
yarn
yarn build
yarn global:link
cd ${{ github.workspace }}
yarn remove @percy/cli && yarn link `echo $PERCY_PACKAGES`
npx percy --version
# Expose the freshly built `percy` on PATH. yarn link symlinks the
# package but not its bin, so `npx percy` would miss it and download
# the unrelated public `percy`. Link is best-effort (non-JS repos have
# no node project to link into); PATH is what makes percy resolvable.
echo "$(yarn global bin)" >> "$GITHUB_PATH"
export PATH="$(yarn global bin):$PATH"
cd ${{ github.workspace }}
yarn remove @percy/cli >/dev/null 2>&1 || true
yarn link `echo $PERCY_PACKAGES` >/dev/null 2>&1 || true
percy --version
- run: npx percy exec --testing -- bundle exec rspec
Loading