improve oauth dev flow and publish frontend ghcr images#38
improve oauth dev flow and publish frontend ghcr images#38phenix3443 wants to merge 28 commits intoperfect-panel:mainfrom
Conversation
Publish frontend images to GHCR
# Conflicts: # apps/admin/src/sections/auth/index.tsx
✅ Deploy Preview for ppane-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
chore: adopt dev branch strategy
docs: deduplicate agent instructions
|
👋 Triage check (2026-04-16): This PR covers multiple improvements (OAuth dev flow, login page fix, GHCR publishing). Looks ready for maintainer review. |
web-ppanel
left a comment
There was a problem hiding this comment.
Thanks for this contribution! The PR is well-structured and covers several meaningful improvements.
Overall assessment: Looks good. A few minor observations:
-
resolve-web-version.tsshell hardcoded to/bin/zsh— theshell: "/bin/zsh"inexecSyncmay fail in CI environments (Ubuntu runners typically don't have zsh). Consider removing theshelloption to use the default/bin/sh, or usebash. -
actions/checkout@v5inpromote-release-branch.yml— v5 doesn't exist yet; the latest stable is v4. This will cause the workflow to fail. -
resolveBaseURL()throws at module init — if neitherVITE_API_BASE_URLnorVITE_API_PREFIXis set, the error is thrown at import time before React mounts, so thetoast.errorcall will never be reached. The error path is correct but the toast is dead code in that scenario. -
Dockerfiles are minimal and functional — the two-line nginx images work fine for static assets.
-
commonReadyflag andskipErrorHandlerforgetUserInfoare good improvements that prevent false error toasts on unauthenticated page loads.
Please address items 1 and 2 before merge, as they will cause CI failures. Item 3 is a minor code quality note.
* fix(ci): address PR 38 review feedback * chore(ci): use actions checkout v6
|
Addressed via Two follow-ups from the earlier review were addressed:
One clarification on the earlier note about Validation:
|
* docs: update branch strategy * fix: update web version metadata and title sync
* ignore local agent instruction files * [codex] fix web version resolution path
|
Triage review (automated): CI checks pass. This PR improves OAuth dev flow, fixes admin login animation layer blocking clicks, and adds GHCR image publishing via GitHub Actions. Prior review concerns appear to have been addressed per contributor's update. Ready for maintainer merge review. |
|
Thanks for the contribution! A previous review (by @web-ppanel) flagged two issues that should be addressed before merge:
Please address these two items and we can proceed with review. The overall direction of the PR looks solid! |
Thanks for the review. Both issues have been fixed in
So these two review items should now be resolved. |
|
Solid set of improvements — the OAuth dev flow enhancements, fixing the animation layer blocking clicks on the login form, and adding GHCR publish workflows are all valuable. Keeping open for maintainer review and merge. |
Summary
ppanel-admin-webandppanel-user-webimages to GHCRValidation