[codex] update web version metadata and title sync#42
[codex] update web version metadata and title sync#42phenix3443 wants to merge 23 commits intoperfect-panel:mainfrom
Conversation
Publish frontend images to GHCR
# Conflicts: # apps/admin/src/sections/auth/index.tsx
chore: adopt dev branch strategy
docs: deduplicate agent instructions
* fix(ci): address PR 38 review feedback * chore(ci): use actions checkout v6
✅ Deploy Preview for ppane-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Triage review (automated): CI checks pass. This PR addresses a real bug (browser tab stuck on 'Loading...' due to react-helmet-async incompatibility with React 19) and bundles version metadata improvements and local dev host allowance. Fixes are frontend-scoped and well-documented. Ready for maintainer merge review. |
|
Thanks for this PR! The fixes for browser tab title sync (replacing react-helmet-async with direct document.title updates) and the structured version metadata are well-motivated — especially given the React 19 peer dependency issue with react-helmet-async. The PR is ready for maintainer review and merge when the team is ready. |
|
Good fixes here. The React 19 compatibility issue with Keeping open for maintainer review and merge. |
What changed
react-helmet-asyncfor runtime title/meta updates and now syncdocument.titleand basic head tags directlyversion.jsonmetadata and expose__APP_GIT_VERSION__to the frontend.home.arpadev hosts by default in Vite so local admin domains likeadmin-ppanel-dev.home.arpaload without extra env configurationWhy
The browser tab title was stuck on
Loading...because the app relied onreact-helmet-async, while this repo is already on React 19 and the library only declares peer support through React 18. In practice, the root route state updated butdocument.titledid not. At the same time, the branch also contains the version metadata changes and local host allowance changes the user asked to publish together.Impact
version.json.home.arpadev domains work without manualVITE_ALLOWED_HOSTSsetupValidation
git diff --cached --checknode node_modules/typescript/bin/tsc -p apps/admin/tsconfig.json --noEmitnode node_modules/typescript/bin/tsc -p apps/user/tsconfig.json --noEmit