Prevent calls to load_plugin_textdomain() too early - #207
Closed
MocioF wants to merge 1 commit into
Closed
Conversation
See: https://make.wordpress.org/core/2024/10/21/i18n-improvements-6-7/ Signed-off-by: Giuseppe Foti <foti.giuseppe@gmail.com>
Collaborator
|
This should be fixed in v1.6.5, as it includes #209. |
Collaborator
|
Thanks for the heads-up and the crucial information about the issue, @MocioF! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://make.wordpress.org/core/2024/10/21/i18n-improvements-6-7/
Since WP version 6.7 when WP_DEBUG is true, the plugin sends a Warning as:
PHP Notice: Function _load_textdomain_just_in_time was called <strong>incorrectly</strong>. Translation loading for the <code>perfecty-push-notifications</code> domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the <code>init</code> action or later. Please see <a href="https://developer.wordpress.org/advanced-administration/debug/debug-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 6.7.0.) in /MYABSPATH/wp-includes/functions.php on line 6121This PR prevents the plugin to be run before init and to load translations too early.