fix bundle-overrides devices remove panic on successful 204 response#236
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a panic in the bundle-overrides devices remove CLI command when the API returns HTTP 204 No Content (successful delete), aligning behavior with other delete-style commands that don’t require a response body.
Changes:
- Update
RemoveDeviceCommand::runto treatNone(no JSON response body) as success instead of panicking.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
The server returns HTTP 204 No Content for successful device removal, which the SDK deserializes as None. The None arm incorrectly called panic!() instead of treating it as success.
lee-reinhardt
force-pushed
the
lee-eng-1472
branch
from
b312e74 to
546df5f
Compare
jasontwong
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoveDeviceCommand::runpanicked when the API returned HTTP 204 No Content (the expected response for a successful delete). Changed theNonearm frompanic!()to a no-op, matching howDeleteCommandalready handles this.