Repository navigation
fix(nexent): keep integration patches free of end-of-line conversion - #2
Merged
Merged
Conversation
Mark integrations/nexent/**/patches/*.patch as -text so a CRLF checkout can no longer break the patch SHA-256 or make git apply report trailing whitespace and fail on the embedded binary tarballs. Document the symptom and remedy in the integration index. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PCEh5gW8GnhGbbykcB15JT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mark
integrations/nexent/**/patches/*.patchas-textin.gitattributesso no checkout can apply end-of-line conversion to the Nexent integration patches, and document the symptom in the integration index. Patch bytes are unchanged.A user applying the patch saw
xxx.patch:297: trailing whitespace.. The patch in the repository has no trailing whitespace on any added line; converting the file to CRLF and runninggit applyreproduces exactly:296:and:297: trailing whitespace.followed by a hard failure inside the embedded binary tarball section, and the SHA-256 no longer matches the manifest.Task reference
docs/event/tasks.mdor explains why none exists.Checks
npm run verify, or documented why it was blocked. (Documentation and attribute change only; ranverify:integration-artifacts,verify:public-identity,verify:docs, andgit diff --check. CI runs the full gate on this PR.)Notes for reviewers
git check-attrnow reportstext: unsetandwhitespace: unsetfor both version directories' patch files.git am --3wayandgit applyand yields the expected result tree.🤖 Generated with Claude Code
https://claude.ai/code/session_01PCEh5gW8GnhGbbykcB15JT
Generated by Claude Code