[Snyk] Security upgrade eslint from 7.32.0 to 10.0.0#15
[Snyk] Security upgrade eslint from 7.32.0 to 10.0.0#15patinthehat wants to merge 1 commit intodevelopfrom
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AJV-15274295
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14ae53155a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "del-cli": "^4.0.1", | ||
| "doctoc": "^2.0.1", | ||
| "eslint": "^7.32.0", | ||
| "eslint": "^10.0.0", |
There was a problem hiding this comment.
Regenerate lockfile for eslint upgrade
This change updates eslint in package.json but leaves package-lock.json pinned to eslint ^7.32.0 (e.g., the root devDependency entry at package-lock.json:29), so lockfile-driven installs (such as npm ci or frozen-lockfile workflows) will not actually pick up the security upgrade and can continue using the vulnerable version.
Useful? React with 👍 / 👎.
| "del-cli": "^4.0.1", | ||
| "doctoc": "^2.0.1", | ||
| "eslint": "^7.32.0", | ||
| "eslint": "^10.0.0", |
There was a problem hiding this comment.
Keep eslint major version compatible with adonis plugin
Bumping to eslint ^10.0.0 makes the dependency graph internally incompatible with the currently declared eslint-plugin-adonis@^1.3.3, which has a peer requirement of eslint ^7.0.0 (package-lock.json:2894-2896); this can cause peer-resolution install failures in stricter environments and leaves npm run lint on an unsupported plugin/ESLint combination.
Useful? React with 👍 / 👎.
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-AJV-15274295
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)