Skip to content

Reset the exit code when the test harness finishes a passing run #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nohwnd merged 2 commits into from
Sep 5, 2026
Merged

Reset the exit code when the test harness finishes a passing run #3040

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
754b8ec
Stop a child process's exit code leaking into the test harness
nohwnd Sep 5, 2026
9f65594
Let the child's exit code through again, only test.ps1 resets it
nohwnd Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions test.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,3 +285,15 @@ if ($CC) {
if ("Failed" -eq $r.Result) {
throw "Run failed!"
}

# Every test passed, so say so with the exit code as well.
#
# Invoke-InNewProcess deliberately lets the child's exit code through, and tests assert on
# it (see "Exitcode is set to the number of failed tests..."), so the helper cannot reset it.
# That means whichever test ran last decides what $LASTEXITCODE holds when we get here, and
# CI ends the step with `exit $LASTEXITCODE`. Without this line a child that exited non-zero
# on purpose turns a fully green run red with no failing test to look at.
#
# This sits after both failure paths above, `exit 1` for P tests and the throw for a failed
# run, so it cannot hide a real failure.
$global:LASTEXITCODE = 0