Source maps?

[petehunt]

@sokra is this good?

[gaearon]

BTW it's potentially breaking right? 0.11 is still RC?
Or did JSX not change?

[petehunt]

yes but i bumped jsx-loader version accordingly

[petehunt]

(i doubt anything actually breaks)

[gaearon]

Ah right I didn't notice -rc on the loader version.

[sokra]

hmm.. i don't think it's good...

It need to be something like:

var result = ....transformWithDetails(...);
this.callback(null, result.code, result.map);

[petehunt]

@sokra are inline sourcemaps supported/

[sokra]

only with the source-map-loader...

So it's better to return it directly... also better for performance...

[jRiest]

@petehunt I added source-map support in my fork here, but it just uses convert-source-map to extract the inlined source map, which I'm sure is far from optimal. Do you want me to create a pull request or do you have a better alternative in the works?

[petehunt]

I'm not really actively working on this so send a pr if it works!

[sokra]

see jRiest@9a0bce4#commitcomment-7486540

[jRiest]

@sokra that's much better. Thanks for pointing that out. I re-implemented sourcemaps using that method and submitted a pull request against this branch (sourcemaps) here