Skip to content

make react-tools a peer dependency#38

Open
nelix wants to merge 2 commits into
petehunt:masterfrom
nelix:patch-1
Open

make react-tools a peer dependency#38
nelix wants to merge 2 commits into
petehunt:masterfrom
nelix:patch-1

Conversation

@nelix

@nelix nelix commented Jan 8, 2015

Copy link
Copy Markdown

this will save some time bumping versions every time a new version of react is released, fixes #29

this will save some time bumping versions every time a new version of react is released, fixes petehunt#29
@waldreiter

Copy link
Copy Markdown

Yes! This is one of the reasons why I use a homemade loader for JSX.

The version < 2 seems random to me. I just use "*".

@nelix

nelix commented Jan 8, 2015

Copy link
Copy Markdown
Author

I'm not really an npm pro, but it needs to be over 0.12.1 but under version 1? But for some reason I typed 2.
So I changed it to 1.

@nelix

nelix commented Feb 12, 2015

Copy link
Copy Markdown
Author

:(

@benmosher

Copy link
Copy Markdown

This, please. 👍

Otherwise, it is difficult to ensure the desired version of react-tools is used for the JSX load, as npm will install the most current version, which may be out of sync with the project's React version.

@coodoo

coodoo commented Apr 9, 2015

Copy link
Copy Markdown

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move react-tools to peerDependencies?

5 participants