Rename git completion file to not conflict with fish#16
Open
rajadain wants to merge 1 commit intopetervanderdoes:developfrom
Open
Rename git completion file to not conflict with fish#16rajadain wants to merge 1 commit intopetervanderdoes:developfrom
rajadain wants to merge 1 commit intopetervanderdoes:developfrom
Conversation
fish ships with a default git.fish file with git completions. When this is installed, it overrides that, and since this relies on functions defined in that default file itself, e.g. __fish_git_branches, it doesn't work. By renaming it to git-flow.fish we ensure it is scoped correctly and works as expected.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fish ships with a default
git.fishfile with git completions. When this is installed, it overrides that, and since this relies on functions defined in that default file itself, e.g.__fish_git_branches, it doesn't work.By renaming it to
git-flow.fishwe ensure it is scoped correctly and works as expected.