Repository navigation
test(printer): wait for both queued jobs before asserting - #57
Merged
Merged
Conversation
PAPPL 1.4.11 starts the newest pending job first (compare_active_jobs sorts by descending job id, and _papplPrinterCheckJobsNoLock starts the first pending entry). The queued-trim case waited only for the follower, so it passed on amd64 only when the first job finished inside the 10 ms poll gap. On a Raspberry Pi Zero 2 W, and under QEMU arm64, the first job was still processing and the assertion failed every run, which also fails the Dockerfile.deploy build on arm64. Wait until both jobs reach a terminal state. Verified 3/3 on the Pi and 12/12 suites on amd64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The queued-trim case in
tests/test_driver.cwaited only for the follower job, then asserted the first job had completed. PAPPL 1.4.11 starts the newest pending job first (compare_active_jobssorts by descending id), so the first job finishes last. It passed on amd64 only because the first job completed inside the 10 ms poll gap.On a Raspberry Pi Zero 2 W (native arm64) and under QEMU arm64,
driver_finishingsanddriver_finishings_p710btfailed every run at thefirst == COMPLETEDassertion, which fails theDockerfile.deploybuild on arm64. PR #52 adds that arm64 build to CI.The fix waits until both jobs are terminal. Verified:
Dockerfile.deploybuild: 12/12 suites pass.Test-only; no behavior change, so no OpenSpec change.