fix(watch): route a hook report to the session that sent it - #38
Merged
Conversation
The daemon matched every report against the worktree path in the payload and took the first session it found there. A worktree is not a unique key — `lcc open` will start a second session in one that already has another — so with four sessions in the same worktree every hook landed on the same row. Measured on PE-289, four sessions deep: the row the reports landed on had already exited, `apply` keeps `exited` terminal, so nothing moved except its `last_event_at`, which is why a dead session carried an activity timestamp two minutes younger than its own death. The two live agents under it were never updated at all — frozen at the `idle` their first byte of output set, whatever they went on to do. The dashboard then merged the worktree onto that same first row, so it reported a corpse for a worktree with two agents working in it, and enter on that row could not attach. Each session now gets its own settings file, `hooks-<id>.json`, with its id baked into every hook command line beside the event — the same reason the event is baked in rather than parsed out of a payload. Reports name their session and route exactly. A report with no id still falls back to the worktree, which is what a session started by an older daemon sends, and both that fallback and the dashboard's merge now prefer a session that is still alive over one that has exited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lcc openstarts a second session in one that already has another — so with four sessions in one worktree every report landed on the same row.hooks-<id>.jsonwith its id baked into every hook command line beside the event, for the same reason the event is baked in rather than parsed out of a payload. A report with no id still falls back to the worktree (that is what an older daemon's sessions send), and both that fallback and the dashboard's worktree merge now prefer a live session over an exited one.Review notes
Measured on PE-289, four sessions deep. The row the reports landed on had already exited;
applykeepsexitedterminal, so nothing moved except itslast_event_at— a dead session carrying an activity timestamp two minutes younger than its own death. The two live agents under it were frozen at theidletheir first byte of output set. The dashboard merged the worktree onto that same first row, so it reported a corpse for a worktree with two agents working in it, and enter on that row could not attach.Both new tests were checked red against the old behaviour before being committed green.
~/.config/lcc/hooks.jsonis now unused and can be deleted; the per-session files are bounded bymax_sessionsand reused, since session ids restart ats-00000001with each daemon.Stacked on #37.