Skip to content

Add is_ipv6_address validation to pfesnsible.core.pfsense_dns_resolver for hosts and domainoverrides #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmckeone wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add is_ipv6_address validation to pfesnsible.core.pfsense_dns_resolver for hosts and domainoverrides #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/modules/pfsense_dns_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,13 +499,13 @@ def _validate_params(self):

for host in params["hosts"]:
for ipaddr in host["ip"].split(","):
if not self.pfsense.is_ipv4_address(ipaddr):
self.module.fail_json(msg=f'ip, {ipaddr} is not a ipv4 address')
if not self.pfsense.is_ipv4_address(ipaddr) and not self.pfsense.is_ipv6_address(ipaddr):
self.module.fail_json(msg=f'ip, {ipaddr} is not a ipv4/ipv6 address')

if params["domainoverrides"] is not None:
for domain in params["domainoverrides"]:
if not self.pfsense.is_ipv4_address(domain["ip"]):
self.module.fail_json(msg=f'ip, {domain["ip"]} is not a ipv4 address')
if not self.pfsense.is_ipv4_address(domain["ip"]) and not self.pfsense.is_ipv6_address(domain["ip"]):
self.module.fail_json(msg=f'ip, {domain["ip"]} is not a ipv4/ipv6 address')

##############################
# XML processing
Expand Down